Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starr-anime): French Anime guide + fixes [TO DELETE] #2135

Closed

Conversation

SeiyaGame
Copy link
Contributor

@SeiyaGame SeiyaGame commented Nov 20, 2024

Pull Request

Purpose

Initial draft of the new french anime guide

Requirements

TODO / Done

  • Add French Anime Tier
  • Add Anime Score for French Tier
  • Add repack for sonarr anime (Same as v1, v2, v3 ...)
  • Add anime part in French Radarr Guide
  • Add FR Anime Tier to the Collection List
  • Remove T3KASHi from FR HD Bluray Tier 01, FR WEB Tier 01 to avoid double scoring, already in FR Anime Tier 01
  • Remove FUJiSAN from FR HD Bluray Tier 02, FR WEB Tier 02 to avoid double scoring, already in FR Anime Tier 02
  • Remove HANAMi from FR HD Bluray Tier 02, FR WEB Tier 02 to avoid double scoring, already in FR Anime Tier 03
  • Testing on a Radarr anime instance (to validate the guide) (In progress)
  • Add quality settings file size for Anime ⚠️ MD5 is same for Sonarr
  • Add TIP for those who prefer fansub to official translations
  • Add MULTI CF in Language Profiles Related Custom Formats Scoring and tip info

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Nov 20, 2024
@SeiyaGame
Copy link
Contributor Author

@TRaSH- I added the quality settings (file size) for Anime but the trash_id on Radarr and Sonarr his the same ...

MD5 of anime: 387e6278d8e06083d813358762e0ac63

Is it okay if I leave it like this? (I suppose not)

@bakerboy448 bakerboy448 added Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information Do Not Merge Do Not Merge labels Dec 3, 2024
dependabot bot and others added 22 commits February 16, 2025 22:01
…des#2269)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.3.0...v5.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.1 to 9.6.3.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.6.1...9.6.3)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…RaSH-Guides#2271)

Bumps [mkdocs-include-markdown-plugin](https://github.com/mondeja/mkdocs-include-markdown-plugin) from 7.1.2 to 7.1.4.
- [Release notes](https://github.com/mondeja/mkdocs-include-markdown-plugin/releases)
- [Commits](mondeja/mkdocs-include-markdown-plugin@v7.1.2...v7.1.4)

---
updated-dependencies:
- dependency-name: mkdocs-include-markdown-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ING.md` (TRaSH-Guides#2272)

* Update CONTRIBUTING.md

Started adding info about
- quality-profiles
- cf-groups

* Fixed: several MD errors

* fix: 210-220: Wrong amount of left-padding spaces(want multiple of 4)

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Try: 990 Wrong amount of left-padding spaces(want multiple of 4)

218-219: Wrong amount of left-padding spaces(want multiple of 4)
221: Wrong amount of left-padding spaces(want multiple of 4)
223-227: Wrong amount of left-padding spaces(want multiple of 4)
284: Wrong amount of left-padding spaces(want multiple of 4)
286: Wrong amount of left-padding spaces(want multiple of 4)
* Fix: Add Groups to German Scene

* Feat: add more Groups

* Feat: add even more Groups

---------

Co-authored-by: Lokilicious <mail.lokilicious.work>
…-Guides#2275)

Revert "build(deps): bump mkdocs-material from 9.6.1 to 9.6.3 (TRaSH-Guides#2270)"

This reverts commit ced6dcd.
TRaSH-Guides#2277)

Revert "Revert "build(deps): bump mkdocs-material from 9.6.1 to 9.6.3" (TRaSH-Guides#2275)"

This reverts commit c64aec2.
…uides#2274)

Added CREATiVE24 to Sonarr lq-release-title custom format
… LQ (release title)` (TRaSH-Guides#2278)

* Feat: add regex matching german tag after RG to to lq (release title)

* Fix: wording

* fix: Improved Regex

Co-authored-by: nuxen <[email protected]>

* fix: Improved Regex

Co-authored-by: nuxen <[email protected]>

---------

Co-authored-by: Lokilicious <mail.lokilicious.work>
Co-authored-by: nuxen <[email protected]>
…TRaSH-Guides#2160)

* feat(guide-sync): Added more groups

* fix: JSONDecodeError

* Added: group Asian Streaming Services

* Added: group UK Streaming Services

* Added: group French Streaming Services

* Added: group Dutch Streaming Services

* Added: group Anime Streaming Services

* Renamed the JSON files so they can be ordered together.

* Add Release Groups

* Updated QP excludes

* Update dv-hdr10-and-hdr10-boost.json

* Changed group names so they are better sorted and matched together

* Remove HDR10+ boost and DV (WEBDL) from the Misc UHD group

* Removed: `x265 (no HDR/DV)` because they aren't part of this profile

* Improved Group name and add `x265 (no HDR/DV)` to the Sonarr UHD Misc

* Removed because they were merged into a single group.

* Added: group SDR

* Add: group golden rule

* Renamed JSON name so they are better sorted

* Added: SQP to the exclude because anime never can be part of the SQP

* Added: descriptions and other changes

* Added: more misc CF

* excludes this group for all QP

* Add group Misc Streaming Services

* fixed: `"required": true` to ` "required": false`

`"required": true` = It means you cant use that group without that format, it can not be turned off!

* Improved Group descriptions

* Added fix for PR#2241

* several needed changes after a talk with the dev of a 3rd party app

* Removed the German 4k excludes

* Added: NEW German `[German] HD Remux + WEB` to the exclude

* Changed order

* Added: [Optional] Resolutions but still disabled for all profiles
…RaSH-Guides#2257)

* Feat: add Radarr Remux 1080p Profile

* Feat: add German HD Remux profile to notifiarr jsons

---------

Co-authored-by: Lokilicious <mail.lokilicious.work>
…nguage CF to avoid double scoring. (TRaSH-Guides#2281)

Fix: DL tag should be required and negated for German Language CF

Co-authored-by: Lokilicious <mail.lokilicious.work>
…#2284)

* feat(misc): Updated the `x265-4k` aka `The Golden Rule`

* Update docs/Misc/x265-4k.md

Co-authored-by: yammes08 <[email protected]>

---------

Co-authored-by: yammes08 <[email protected]>
* fix(guide-sync): Profile exclusions

* Make it one click and not selectable for one single CF

* Removed forced `x265 (HD)` and `x265 (no HDR/DV)` because it's selectable now
@github-actions github-actions bot added Area: github_actions Github Actions Related Area: Downloaders Downloaders Related labels Feb 16, 2025
@SeiyaGame
Copy link
Contributor Author

I rebased but I forgot to force push, I fucked my PR ...

@SeiyaGame
Copy link
Contributor Author

I'll do another PR

@SeiyaGame SeiyaGame changed the title feat(starr-anime): French Anime guide + fixes feat(starr-anime): French Anime guide + fixes [TO DELETE] Feb 16, 2025
@yammes08
Copy link
Contributor

Closing as per comment above

@yammes08 yammes08 closed this Feb 16, 2025
@SeiyaGame SeiyaGame deleted the feat/Radarr-french-anime-guide-v2 branch February 16, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related Area: github_actions Github Actions Related Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Do Not Merge Do Not Merge Status: Conflicted Pull Request is Conflicted Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information
Projects
None yet
Development

Successfully merging this pull request may close these issues.