Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert most of the change from #1006 #1173

Merged
merged 2 commits into from
Dec 12, 2023
Merged

revert most of the change from #1006 #1173

merged 2 commits into from
Dec 12, 2023

Conversation

TimGoll
Copy link
Member

@TimGoll TimGoll commented Dec 12, 2023

PR #1006 tried to simplify the gametext entity. While doing so it changed many things that break the functionality. This one is on us for being to lax while reviewing it. Most of these changes should not have been done.

@TimGoll
Copy link
Member Author

TimGoll commented Dec 12, 2023

image

The error was caused by maps trying to send messages to MStack and failing

@TimGoll TimGoll linked an issue Dec 12, 2023 that may be closed by this pull request
@saibotk saibotk merged commit 658178f into master Dec 12, 2023
4 checks passed
@saibotk saibotk deleted the fix-ttt_game_test branch December 12, 2023 08:42
@Histalek Histalek added this to the v0.12.xb milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in the console at round start
4 participants