Ammo Drop from reserve now tries to drop a full box, instead of, at most, a full clip #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed ammo dropped to drop full box if possible instead of clip. Fixes weird scenarios with weapons that have low clipsize where you need to spam ammo drop to drop the equivalent of a full box of ammo.
added myself to changes
TimGoll
approved these changes
Dec 9, 2024
Histalek
pushed a commit
that referenced
this pull request
Dec 10, 2024
…ost, a full clip (#1694) Ammo dropping from the reserve was a bit weird. You currently drop `Min(Clipsize, Reserve)`, which is fine for default weapons where clip size = box ammo, but for any custom weapon with less ammo, things get increasingly weird. The worst-case scenario involves weapons with super-low ammo. Consider the often-used pocket rifle, which has only a clip size of 1; here, you must drop ammo 10 times to drop the same as a regular 357 box. My change makes it so that instead, you now drop `Min(Box Size, Reserve)`, which feels much better and has no downsides I can see. Dropping from the clip remains unchanged as it should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ammo dropping from the reserve was a bit weird. You currently drop
Min(Clipsize, Reserve), which is fine for default weapons where clip size = box ammo, but for any custom weapon with less ammo, things get increasingly weird.The worst-case scenario involves weapons with super-low ammo. Consider the often-used pocket rifle, which has only a clip size of 1; here, you must drop ammo 10 times to drop the same as a regular 357 box.
My change makes it so that instead, you now drop
Min(Box Size, Reserve), which feels much better and has no downsides I can see. Dropping from the clip remains unchanged as it should.