Fix: Prevent spectators, covert, and long range corpse searches from making sound #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibotk
approved these changes
Dec 26, 2024
|
Can you quickly merge the if statement into a single line to make stylua happy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new corpse searching sounds play when anything searches them in any manner. The main example being spectators - if a spectator examined a body, the body would make a sound seemingly out of nowhere for players who are alive.
Covert searches and long range searches also cause the search sound to play which seems wrong.
The change in this PR fixes that. The sound will now only play if the player is alive (using IsTerror), and if the search wasn't covert or long range.