Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

[Feature] Navigation API Translation #1510

Closed
CommanderStorm opened this issue Sep 15, 2022 · 1 comment · Fixed by #1529
Closed

[Feature] Navigation API Translation #1510

CommanderStorm opened this issue Sep 15, 2022 · 1 comment · Fixed by #1529

Comments

@CommanderStorm
Copy link
Member

Is your feature request related to a problem? Please describe.
During the development of #1462 (more precicely in #1462 (comment)) we noticed, that the navigaTUM API is not localised and thus decided that hacks like

private fun getTranslationForPropertyTitle(title: String): String {
are needed

Describe the solution you'd like
NavigaTUM has added the lang cookie/query parameter to translate these APIs. We should utilize them instead of our homegrown translation.

Describe alternatives you've considered
There are no alternatives 😉

Additional context
The API Documentation is availiable at https://nav.tum.sexy/api

@ctsk
Copy link
Contributor

ctsk commented Nov 14, 2022

I stumbled upon this today! Will work on it later. This leads to some location properties not being "translated" properly, aswell as mismatched naming of things in the app vs on nav.tum.sexy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants