This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Feature/navigatum localization #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctsk
commented
Nov 14, 2022
Comment on lines
110
to
116
| private fun showNavigationDetailsProperties(navigationDetails: NavigationDetails) { | ||
| navigationDetails.properties.forEach { property -> | ||
| val propertyRow = NavigationPropertyRowBinding.inflate(layoutInflater, binding.propsList, true) | ||
| propertyRow.propertyName.text = getTranslationForPropertyTitle(property.title) | ||
| propertyRow.propertyName.text = property.title | ||
| propertyRow.propertyValue.text = property.value | ||
| } | ||
| } |
There was a problem hiding this comment.
Perhaps someone with more android-fu can help me here. Is it possible to do this more elegantly with bindings, now that we don't do the translation anymore?
There was a problem hiding this comment.
I dont know of a better way
CommanderStorm
approved these changes
Nov 14, 2022
app/src/main/java/de/tum/in/tumcampusapp/component/other/locations/LocationManager.kt
Outdated
Show resolved
Hide resolved
Comment on lines
110
to
116
| private fun showNavigationDetailsProperties(navigationDetails: NavigationDetails) { | ||
| navigationDetails.properties.forEach { property -> | ||
| val propertyRow = NavigationPropertyRowBinding.inflate(layoutInflater, binding.propsList, true) | ||
| propertyRow.propertyName.text = getTranslationForPropertyTitle(property.title) | ||
| propertyRow.propertyName.text = property.title | ||
| propertyRow.propertyValue.text = property.value | ||
| } | ||
| } |
There was a problem hiding this comment.
I dont know of a better way
app/src/main/java/de/tum/in/tumcampusapp/component/other/locations/LocationManager.kt
Outdated
Show resolved
Hide resolved
CommanderStorm
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Add language parameter to navigatum queries * Remove 'getTranslationForPropertyTitle'
CommanderStorm
pushed a commit
that referenced
this pull request
Nov 14, 2022
* Add language parameter to navigatum queries * Remove 'getTranslationForPropertyTitle'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This fixes the following issue(s):
Screenshot
Note how the names of the properties are properly translated
Why this is useful for all students
Makes the apps localization more consistent :)