open nav.tum.sexy to show location #1443
Conversation
|
As long as the in app roomfinder does not work this seems to be a reasonable way to go 👌 |
|
Yes this works with us. We have changed the URLs last week to accommodate this feature. @kmodexc is working on that too, so I see no problem in merging this |
|
I'd probably recommend to instead do this in an in-app webview instead of opening an external browser: https://developer.android.com/guide/webapps/webview |
|
@kordianbruck Good idea. i will do this |
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/calendar/NavigatumActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/tum/in/tumcampusapp/component/tumui/calendar/CalendarDetailsFragment.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
|
@CommanderStorm Was a good idea. Hopefully this is consistent with the notation in other places. |
|
@kordianbruck can you review this? |
CommanderStorm
requested review from
joschahenningsen
and removed request for
CommanderStorm
There was a problem hiding this comment.
Looks good to me. Happy to work on #1451 if no one picked it up already :)
* open nav.tum.sexy to show location * calender detail call navigatumactivity * add NavigatumActivity to manifest * create NavigatumActivity * remove unused import * change namestyle Co-authored-by: Frank Elsinga <[email protected]> * change namestyle Co-authored-by: Frank Elsinga <[email protected]> * change namestyle Co-authored-by: Frank Elsinga <[email protected]> Co-authored-by: Frank Elsinga <[email protected]>
Issue
This fixes the following issue(s):
This only opens nav.tum.sexy and does not have an in-app map. However i think that ok for now and solves the issue for me.
On step for #1437