Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Scroll Bug #1119

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Firefox Scroll Bug #1119

merged 2 commits into from
Aug 15, 2023

Conversation

MatthiasReumann
Copy link
Collaborator

Motivation and Context

Resolves #1107

Description

Add h-full and overflow-y-scroll to prevent the overflowing of the parent container (which caused the bug)

Steps for Testing

  • 1 Account
  1. Log in
  2. Click User Courses [Public Courses]
  3. Scroll to Bottom
  4. Click on course
  5. Course page should be visible
  6. ⭐️

@github-actions
Copy link

Your Testserver will be ready at https://1119.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@joschahenningsen joschahenningsen merged commit 2f544f1 into dev Aug 15, 2023
9 checks passed
@joschahenningsen joschahenningsen deleted the bug/firefox-scroll branch August 15, 2023 20:57
SebiWrn pushed a commit that referenced this pull request May 7, 2024
* Fix background-size:cover

* Fix scroll bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Course page invisible due to wrong scrolling position
2 participants