Course page updates #1122
Merged
Course page updates #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1122.test.live.mm.rbg.tum.de in a few minutes. Logins
|
MatthiasReumann
requested review from
mono424,
alexanderstephan and
joschahenningsen
joschahenningsen
requested changes
Aug 22, 2023
web/ts/components/course.ts
Outdated
| @@ -137,6 +135,10 @@ export function courseContext(slug: string, year: number, term: string, userId: | |||
| dropdown.toggle(false); | |||
| }, | |||
|
|
|||
| getMonthName(m: number): string { | |||
| return Intl.DateTimeFormat("locale", { month: "long" }).format(new Date(m)); // January | |||
There was a problem hiding this comment.
This doesn't work for me, I always get "January" or sometimes the error "date value is not finite in DateTimeFormat.format()"
Maybe we should keep it simple like this, since we don't localize anyway?
Suggested change
| return Intl.DateTimeFormat("locale", { month: "long" }).format(new Date(m)); // January | |
| return ["January", "February", "March", "April", "May", "June", | |
| "July", "August", "September", "October", "November", "December" | |
| ][m-1]; |
There was a problem hiding this comment.
Yup, agree.
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Add smart array * Add GroupedSmartArray * Update groupedsmartarray * Add sorting * Fix variable vod title length due to ellipsis button * Update grid sizing * Lint * Add ts-ignore * Fix lint (2) * Fix lint (3) * Lint * Lint please work * Lint :-) * Fix download * Update getMonthName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improve usability of the course page.
& Resolve #1090 for new UI
Description
Steps for Testing
Prerequisites: