Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve semester selection in home sidebar #1139

Merged

Conversation

JosefSchoenberger
Copy link
Contributor

@JosefSchoenberger JosefSchoenberger commented Aug 23, 2023

Motivation and Context

Resolves #1138.

Description

Adds /20xx to all winter semesters in the semester selection sidebar.
Also increases bottom margin on the currently selected semester.

Steps for Testing

  1. Go to home view
  2. Notice the changes on the sidebar
  3. Click on "show all"
  4. Notice the changes here as well.

Screenshots

grafik

grafik

@JosefSchoenberger JosefSchoenberger force-pushed the enh/better-semester-selection branch 2 times, most recently from ca532b4 to e0a0080 Compare August 23, 2023 12:26
Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd go for something like 2023/24 like here https://tu-film.de/programm, but I have no strong opinion on this. @alexanderstephan feel free to merge whenever fine for you

@JosefSchoenberger
Copy link
Contributor Author

Personally, I'd go for something like 2023/24 like here https://tu-film.de/programm, but I have no strong opinion on this.

Sure, why not?

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not too opinionated on this one. Looks good! 🎉

@alexanderstephan alexanderstephan merged commit 805c3c3 into TUM-Dev:dev Aug 23, 2023
7 of 8 checks passed
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Adds /20xx to all winter semesters in the semester selection sidebar.
Also increases bottom margin on the currently selected semester.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "/20xx" to wintersemesters in sidebar
3 participants