Added Filter by Role to user search #1278
Open
+53
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1278.test.live.mm.rbg.tum.de in a few minutes. Logins
|
|
There's a small problem: after filtering, the user's email doesn't seem to be displayed |
|
Filtering locally results in no show of potential results. Simplest case of this is filtering for students without query string. Change the API instead. |
I cannot reproduce this problem in Mozilla Firefox for Ubuntu 132.0.2 (64-Bit) or Google Chrome Version 130.0.6723.58 (Official Build) (64-bit). |
joschahenningsen
requested changes
Nov 22, 2024
Co-authored-by: Joscha Henningsen <[email protected]>
| users, err = r.UsersDao.SearchUser(q) | ||
| role, err := strconv.ParseUint(rQ, 10, 64) | ||
| if err != nil && rQ != "" && rQ != "-1" { | ||
| tools.RenderErrorPage(c, http.StatusBadRequest, "invalid role") |
There was a problem hiding this comment.
API endpoints should not render HTML pages on error but rather use
Line 31 in 95804eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
You can now filter users by their role, improves administration and overview over admins.
Steps for Testing
Prerequisites:
Screenshots