Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apiv2): stream and progress endpoints for API v2 #1495

Merged
merged 29 commits into from
Feb 12, 2025
Merged

Conversation

carlobortolan
Copy link
Member

@carlobortolan carlobortolan commented Feb 9, 2025

Motivation and Context

See #1415.

Description

  • Add stream and progress related endpoints (see stream.go and progress.go) to get details, playlists, sections, subtitles and thumbnails for a stream and progresses
  • Rename GetLiveStreams APIv2 endpoint to GetLiveCourses
  • Add authorizeUserForStreamCourse method to check if user is allowed to access a specific stream (<- open for feedback/alternative approaches)
  • Clean up protofile and remove duplicate /api/v2 path in routes for HTTP proxy
  • Add google/api/httpbody.proto to support custom response body filetypes (e.g., text/vtt for subtitles or image/jpeg for the thumbnails)
  • Fix duplicate Notification message bug (see related feat(runner): heartbeat #1493 and feat(apiv2): bookmark and notification endpoints for API v2 #1492)

Steps for Testing

Test gRPC API:

  1. Fork postman.com/tumdev/team-workspace/collection/66dba0f1406ecba7a2d44836 or use apiv2.proto
  2. Try out different requests

Test HTTP/REST proxy:

  1. Open localhost:8081/api/v2/docs
  2. Try out different requests

Screenshots

List of new endpoints:
image
image

carlobortolan and others added 26 commits January 8, 2025 00:42
@carlobortolan carlobortolan self-assigned this Feb 9, 2025
@carlobortolan carlobortolan mentioned this pull request Feb 9, 2025
7 tasks
@carlobortolan carlobortolan marked this pull request as ready for review February 11, 2025 00:40
@carlobortolan carlobortolan requested a review from a team February 11, 2025 00:40
Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@joschahenningsen joschahenningsen merged commit fb1836a into dev Feb 12, 2025
9 checks passed
@joschahenningsen joschahenningsen deleted the api_v2 branch February 12, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants