feat(runner/metrics): Add metric broker #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca0034a.
joschahenningsen
force-pushed
the
feat/runner-metrics
branch
from
a3f49cf to
590a562
Compare
| } | ||
|
|
||
| // With initializes a new LabelBuilder. | ||
| func (b *Broker) With() LabelBuilder { |
There was a problem hiding this comment.
nit: In rust this would be named
Suggested change
| func (b *Broker) With() LabelBuilder { | |
| func (b *Broker) Builder() LabelBuilder { |
There was a problem hiding this comment.
I went for this because it allows using the api like so b.With().Stream(123).Input("rtmp://1.2.3.4/src"), which is shorter and quite naturally readable
CommanderStorm
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1494, merge after.
Motivation and Context
Description
Steps for Testing
only code review