Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Solidity language #1681

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

ret2libc
Copy link
Contributor

No description provided.

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, could you:

  1. Update the PR title to make the semantic PR check pass?
  2. Please confirm you've verify this PR works, using tabby scheduler --now and visualization inside of code browser.

website/docs/programming-languages.md Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys marked this pull request as draft March 18, 2024 01:09
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.92%. Comparing base (136d420) to head (83e896b).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1681      +/-   ##
==========================================
- Coverage   54.02%   53.92%   -0.11%     
==========================================
  Files         115      115              
  Lines        9604     9612       +8     
==========================================
- Hits         5189     5183       -6     
- Misses       4415     4429      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ret2libc ret2libc changed the title Add Solidity language feat: Add Solidity language Mar 20, 2024
@ret2libc ret2libc force-pushed the solidity-language branch from 774c4f1 to 83e896b Compare March 20, 2024 10:55
@ret2libc
Copy link
Contributor Author

ret2libc commented Mar 20, 2024

Thanks for the PR, could you:

  1. Update the PR title to make the semantic PR check pass?

Done

  1. Please confirm you've verify this PR works, using tabby scheduler --now and visualization inside of code browser.

I have ran tabby scheduler --now and it did build the index for my solidity project, i've also played a bit with tabby installed in vscode . What do you mean exactly with "visualization inside of code browser"? Is there any specific thing I should check/do in vscode to see it works?

@wsxiaoys
Copy link
Member

I have ran tabby scheduler --now and it did build the index for my solidity project, i've also played a bit with tabby installed in vscode . What do you mean exactly with "visualization inside of code browser"? Is there any specific thing I should check/do in vscode to see it works?

You can enable the web ui by following https://tabby.tabbyml.com/docs/administration/, config the repository with git providers, then use the Code Browser in avatar menu to verify if the treesitter queries works as expected

image

@ret2libc
Copy link
Contributor Author

I have ran tabby scheduler --now and it did build the index for my solidity project, i've also played a bit with tabby installed in vscode . What do you mean exactly with "visualization inside of code browser"? Is there any specific thing I should check/do in vscode to see it works?

You can enable the web ui by following https://tabby.tabbyml.com/docs/administration/, config the repository with git providers, then use the Code Browser in avatar menu to verify if the treesitter queries works as expected

image

I can confirm things show correctly in the code browser!
image

@ret2libc ret2libc marked this pull request as ready for review March 20, 2024 14:51
@ret2libc ret2libc requested a review from wsxiaoys March 20, 2024 14:51
@wsxiaoys
Copy link
Member

I have ran tabby scheduler --now and it did build the index for my solidity project, i've also played a bit with tabby installed in vscode . What do you mean exactly with "visualization inside of code browser"? Is there any specific thing I should check/do in vscode to see it works?

You can enable the web ui by following https://tabby.tabbyml.com/docs/administration/, config the repository with git providers, then use the Code Browser in avatar menu to verify if the treesitter queries works as expected
image

I can confirm things show correctly in the code browser! image

You should be able to see something highlighted as screenshot shows if the treesitter queries works for solidity code. Could you doulbe check?

image

@ret2libc
Copy link
Contributor Author

image

however this kind of highlighting only happens for very simple files. Even for a C file that is not super simple, something is not triggering the highlight. This, however, is probably a problem not related to solidity.

@wsxiaoys wsxiaoys merged commit 8203dd9 into TabbyML:main Mar 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants