Add team metrics to speakers #2572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tienne-B
reviewed
Jan 3, 2025
tabbycat/standings/speakers.py
Outdated
Comment on lines
99
to
109
| def get_annotation(self, round): | ||
| """Returns a QuerySet annotated with the number of wins for the team of the speaker.""" | ||
| annotation_filter = Q( | ||
| team__debateteam__teamscore__ballot_submission__confirmed=True, | ||
| team__debateteam__debate__round__stage=Round.Stage.PRELIMINARY, | ||
| team__debateteam__teamscore__win=self.where_value, | ||
| ) | ||
| if round is not None: | ||
| annotation_filter &= Q(team__debateteam__debate__round__seq__lte=round.seq) | ||
|
|
||
| return self.function('team__debateteam__teamscore__win', filter=annotation_filter) |
There was a problem hiding this comment.
We should be able to create a superclass for these that abstracts these out, like what's done for teams.py.
There was a problem hiding this comment.
Hey! I've pushed up a change to use a dedicated subclass rather than a big if. Thoughts, @TrudeauOkech ?
There was a problem hiding this comment.
Yup, this works too!
TrudeauOkech
changed the title
tienne-B
force-pushed
the
add-team-metrics-to-speakers
branch
from
9911847 to
72aff35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2553
Added the following team metrics to break speaker ties.
Team wins
Number of 1sts
Number of seconds
Number of 3rds
Votes/ballots