Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests into CI #286

Merged
merged 1 commit into from
Jun 13, 2024
Merged

add tests into CI #286

merged 1 commit into from
Jun 13, 2024

Conversation

yedpodtrzitko
Copy link
Collaborator

@yedpodtrzitko yedpodtrzitko commented Jun 13, 2024 •
edited
Loading

partially overlaps with #199, but that one has several issues, so it feels faster to do it from scratch and add some real tests at that opportunity.

@yedpodtrzitko yedpodtrzitko marked this pull request as draft June 13, 2024 20:18
@CyanVoxel CyanVoxel added Type: Tests Tests or testing related Type: CI Continuous Integration / workflows Priority: High An important issue requiring attention labels Jun 13, 2024
@yedpodtrzitko yedpodtrzitko force-pushed the yed/pytest-ci branch 2 times, most recently from 53217c2 to 50ebcd1 Compare June 13, 2024 20:24
@yedpodtrzitko yedpodtrzitko marked this pull request as ready for review June 13, 2024 20:25
@CyanVoxel CyanVoxel self-assigned this Jun 13, 2024
CyanVoxel
CyanVoxel approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A much-needed kickstart for tests, thanks for getting this going! I suppose either #199 can be revisited after this or it can be closed in favor of a new PR with additional tests.

@CyanVoxel CyanVoxel merged commit aa2925c into TagStudioDev:main Jun 13, 2024
4 checks passed
lunaro-4 pushed a commit to lunaro-4/TagStudio that referenced this pull request Jun 14, 2024
@yedpodtrzitko @lunaro-4
add pytest to CI pipeline (TagStudioDev#286)
931ac8b
lunaro-4 pushed a commit to lunaro-4/TagStudio that referenced this pull request Jun 14, 2024
@yedpodtrzitko @lunaro-4
add pytest to CI pipeline (TagStudioDev#286)
ad01978
@yedpodtrzitko yedpodtrzitko deleted the yed/pytest-ci branch November 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees

@CyanVoxel CyanVoxel

Labels
Priority: High An important issue requiring attention Type: CI Continuous Integration / workflows Type: Tests Tests or testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yedpodtrzitko @CyanVoxel