Issue/59 #66
Merged
Issue/59 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiyuki-140
had a problem deploying
to
preview
GitHub Actions
Failure
yoshiyuki-140
had a problem deploying
to
preview
GitHub Actions
Failure
yoshiyuki-140
had a problem deploying
to
preview
GitHub Actions
Failure
Taka1304
reviewed
Oct 31, 2024
yoshiyuki-140
had a problem deploying
to
preview
GitHub Actions
Failure
Closed
|
merge先のブランチを変えてそこでCIが通るか確認します！ |
よろしくお願い致します 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59
やったこと
クエリを追加しました。
カテゴリ検索を行うためにクライアントサイドコンポーネントが必要になったので、増築しました。
タイトルに文字列が含まれているか否かを検索するためにはクライアントサイドコンポーネントが必要とのことで、追記
画面
その他
クライアントサイドコンポーネントが今回の実装にあたって本当に必要だったか、無駄なファイルを増築しているのではないかという点が、懸念されます。
そのあたりの、知見も含めてご教示いただければ幸いです。
よろしくお願い致します。 🙇🏽♂️