Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ARCH-482): remove reakit from design-system #4751

Merged
merged 235 commits into from
Oct 19, 2023

Conversation

jmfrancois
Copy link
Collaborator

@jmfrancois jmfrancois commented Jun 6, 2023

What is the problem this PR is trying to solve?

As reakit is not maintained and it doesn't works with @types/react 18 we are blocked

What is the chosen solution to this problem?

Let's remove it and assume we can support accessibility if we own the code.

  • First iteration is to have a build that works without reakit.
  • A second iteration will be done to enforce some check around accessibility

http://4751.talend.surge.sh/


Menu Design System

  • Missing Accordion menu
    Fixed (import to update)

Menu Design Tokens > Light [Dark] > Colors

  • Tabs on top not working => Infinte loop with useEffect
    Fixed (rework state management)

Menu Design Tokens > Light [Dark] > Color Compositions

  • Tabs on top not working => Infinte loop with useEffect
    Fixed (rework state management)

Menu Design System > Clickable > ButtonIcon

  • There is no more gap between button and its tooltip when mouse is over
    Fixed (udpate style)

Menu Design System > Combobox

  • Clicking out opened dropdown menu no more close it
    Fixed (add onBlur event listener)
  • Click in input field to open dropdown menu and press Escape to close it. Click again in input field : dropdown menu is not displayed
    Fixed (add onClick event listener)

Menu Design System > Divider

  • Divider without specified orientation is no more displayed
    Fixed (add default orientation value)

Menu Design System > Drawer

  • Drawer is not displayed
    Component has been removed. Clone developed (action from jmfrancois)

Menu Design System > Dropdown

  • Dropdown menu is not well positioned
    Fixed (add placement & update style)
  • Caret icon orientation don't change when opening menu

Menu Design System > Form > Form Fields > Checkbox

  • Default status don't work
    Fixed (rework state management)
  • Story with submit seems not to work correctly (no form data)
    Fixed (rework state management)

Menu Design System > Form > Form Fields > ToggleSwitch

  • In story with submit, option B value is inverted
    Fixed (rework state management)

Menu Design System > Modal

  • Click out not working anymore
    Fixed (add onClick event listener)

Menu Design System > Popover

  • Update storybook

Menu Design System > Switch

  • Selected item color is not "var(--coral-color-accent-text-weak, white)"
    Fixed (update style and fix code)

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe June 6, 2023 16:37 — with GitHub Actions Inactive
@jmfrancois jmfrancois had a problem deploying to pull_request_unsafe June 6, 2023 16:37 — with GitHub Actions Failure
@jmfrancois jmfrancois had a problem deploying to pull_request_unsafe June 6, 2023 16:37 — with GitHub Actions Failure
@jmfrancois jmfrancois had a problem deploying to pull_request_unsafe June 6, 2023 16:37 — with GitHub Actions Failure
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 18, 2023 16:26 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 18, 2023 16:27 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 18, 2023 16:27 — with GitHub Actions Inactive
Copy link
Contributor

@smouillour smouillour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this work.
I just added 2 or 3 comments

packages/design-system/src/components/Tabs/index.ts Outdated Show resolved Hide resolved
packages/design-system/src/index.ts Show resolved Hide resolved
packages/design-system/.eslintrc.json Outdated Show resolved Hide resolved
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 19, 2023 07:30 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 19, 2023 07:41 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 19, 2023 07:42 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 19, 2023 07:42 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 19, 2023 07:42 — with GitHub Actions Inactive
@jmfrancois jmfrancois merged commit 9a0732e into master Oct 19, 2023
@jmfrancois jmfrancois deleted the jmfrancois/chore/ds-no-reakit branch October 19, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants