-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ARCH-482): remove reakit from design-system #4751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove webpack builder as it do not exists anymore add framework config upgrade to latest rc
jmfrancois
temporarily deployed
to
pull_request_unsafe
June 6, 2023 16:37 — with
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
June 6, 2023 16:37 — with
GitHub Actions
Failure
jmfrancois
had a problem deploying
to
pull_request_unsafe
June 6, 2023 16:37 — with
GitHub Actions
Failure
jmfrancois
had a problem deploying
to
pull_request_unsafe
June 6, 2023 16:37 — with
GitHub Actions
Failure
jmfrancois
had a problem deploying
to
pull_request_unsafe
June 6, 2023 16:37 — with
GitHub Actions
Error
jmfrancois
commented
Jun 6, 2023
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 18, 2023 16:20 — with
GitHub Actions
Error
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 18, 2023 16:26 — with
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 18, 2023 16:26 — with
GitHub Actions
Error
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 18, 2023 16:26 — with
GitHub Actions
Error
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 18, 2023 16:26 — with
GitHub Actions
Error
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 18, 2023 16:27 — with
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 18, 2023 16:27 — with
GitHub Actions
Failure
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 18, 2023 16:27 — with
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 18, 2023 16:27 — with
GitHub Actions
Failure
smouillour
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this work.
I just added 2 or 3 comments
packages/design-system/src/stories/form/ToggleSwitch/ToggleSwitch.stories.tsx
Outdated
Show resolved
Hide resolved
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 19, 2023 07:30 — with
GitHub Actions
Inactive
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 19, 2023 07:30 — with
GitHub Actions
Error
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 19, 2023 07:30 — with
GitHub Actions
Error
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 19, 2023 07:30 — with
GitHub Actions
Error
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 19, 2023 07:41 — with
GitHub Actions
Inactive
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 19, 2023 07:42 — with
GitHub Actions
Inactive
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 19, 2023 07:42 — with
GitHub Actions
Inactive
jmfrancois
temporarily deployed
to
pull_request_unsafe
October 19, 2023 07:42 — with
GitHub Actions
Inactive
sgendre
approved these changes
Oct 19, 2023
smouillour
approved these changes
Oct 19, 2023
smouillour
approved these changes
Oct 19, 2023
jmfrancois
had a problem deploying
to
pull_request_unsafe
October 19, 2023 13:00 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
As reakit is not maintained and it doesn't works with @types/react 18 we are blocked
What is the chosen solution to this problem?
Let's remove it and assume we can support accessibility if we own the code.
http://4751.talend.surge.sh/
Menu Design System
Fixed (import to update)
Menu Design Tokens > Light [Dark] > Colors
Fixed (rework state management)
Menu Design Tokens > Light [Dark] > Color Compositions
Fixed (rework state management)
Menu Design System > Clickable > ButtonIcon
Fixed (udpate style)
Menu Design System > Combobox
Fixed (add onBlur event listener)
Fixed (add onClick event listener)
Menu Design System > Divider
Fixed (add default orientation value)
Menu Design System > Drawer
Component has been removed. Clone developed (action from jmfrancois)
Menu Design System > Dropdown
Fixed (add placement & update style)
Menu Design System > Form > Form Fields > Checkbox
Fixed (rework state management)
Fixed (rework state management)
Menu Design System > Form > Form Fields > ToggleSwitch
Fixed (rework state management)
Menu Design System > Modal
Fixed (add onClick event listener)
Menu Design System > Popover
Menu Design System > Switch
Fixed (update style and fix code)
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change