Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forms): migrate to DS Tabs + CollapsibleFieldset #4928

Merged
merged 18 commits into from
Nov 28, 2023

update failing snapshot

5c959b2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat(forms): migrate to DS Tabs + CollapsibleFieldset #4928

update failing snapshot
5c959b2
Select commit
Loading
Failed to load commit list.
GitHub Actions / ESLint Report Analysis succeeded Nov 27, 2023 in 2s

ESLint Report Analysis

0 ESLint error(s) and 28 ESLint warning(s) found in pull request changed files.
0 ESLint error(s) and 0 ESLint warning(s) found in files outside of the pull request.

Details

Annotations

Check warning on line 2 in packages/design-system/src/components/Tabs/Primitive/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/Primitive/Tabs.tsx#L2 

[prettier/prettier] Replace `import·{·SizedIcon·}·from·'../../Icon';` with `⏎import·classNames·from·'classnames';⏎⏎import·{·IconNameWithSize·}·from·'@talend/icons';⏎`

Check warning on line 3 in packages/design-system/src/components/Tabs/Primitive/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/Primitive/Tabs.tsx#L3 

[prettier/prettier] Replace `TagDefault·}·from·'../../Tag` with `SizedIcon·}·from·'../../Icon`

Check warning on line 5 in packages/design-system/src/components/Tabs/Primitive/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/Primitive/Tabs.tsx#L5 

[prettier/prettier] Replace `bsInternalContext·}·from·'./TabsProvider` with `gDefault·}·from·'../../Tag`

Check warning on line 7 in packages/design-system/src/components/Tabs/Primitive/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/Primitive/Tabs.tsx#L7 

[prettier/prettier] Replace `style·from·'./TabStyles.module.scss';` with `{·TabsInternalContext·}·from·'./TabsProvider';⏎`

Check warning on line 9 in packages/design-system/src/components/Tabs/Primitive/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/Primitive/Tabs.tsx#L8-L9 

[prettier/prettier] Replace `{·IconNameWithSize·}·from·'@talend/icons';⏎import·classNames·from·'classname` with `style·from·'./TabStyles.module.scs`

Check warning on line 1 in packages/design-system/src/components/Tabs/variants/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/variants/Tabs.tsx#L1 

[prettier/prettier] Replace `TabsProvider,·TabsProviderPropTypes·}·from·'../Primitive/TabsProvider` with `useEffect,·useState·}·from·'react';⏎⏎import·{·randomUUID·}·from·'@talend/utils';⏎⏎import·{·TabPanel,·TabPanelPropTypes·}·from·'../Primitive/TabPanel`

Check warning on line 2 in packages/design-system/src/components/Tabs/variants/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/variants/Tabs.tsx#L2 

[prettier/prettier] Replace `s·as·TabList,·Tab` with `,·Tabs·as·TabList`

Check warning on line 5 in packages/design-system/src/components/Tabs/variants/Tabs.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/components/Tabs/variants/Tabs.tsx#L3-L5 

[prettier/prettier] Replace `Panel,·TabPanelPropTypes·}·from·'../Primitive/TabPanel';⏎import·{·useEffect,·useState·}·from·'react';⏎import·{·randomUUID·}·from·'@talend/utils` with `sProvider,·TabsProviderPropTypes·}·from·'../Primitive/TabsProvider`

Check warning on line 2 in packages/design-system/src/stories/navigation/Tabs.stories.tsx

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/design-system/src/stories/navigation/Tabs.stories.tsx#L2 

[prettier/prettier] Insert `⏎`

Check warning on line 2 in packages/forms/src/UIForm/fieldsets/Array/Array.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/Array/Array.component.js#L1-L2 

[prettier/prettier] Delete `import·PropTypes·from·'prop-types';⏎`

Check warning on line 3 in packages/forms/src/UIForm/fieldsets/Array/Array.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/Array/Array.component.js#L3 

[prettier/prettier] Replace `import·{·head,·get` with `⏎import·{·get,·head`

Check warning on line 4 in packages/forms/src/UIForm/fieldsets/Array/Array.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/Array/Array.component.js#L4 

[prettier/prettier] Replace `Widget·from·'../../Widget';` with `PropTypes·from·'prop-types';⏎`

Check warning on line 5 in packages/forms/src/UIForm/fieldsets/Array/Array.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/Array/Array.component.js#L5 

[prettier/prettier] Replace `shiftArrayErrorsKeys·}·from·'../../utils/validation` with `getArrayElementSchema·}·from·'../../utils/array`

Check warning on line 7 in packages/forms/src/UIForm/fieldsets/Array/Array.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/Array/Array.component.js#L7 

[prettier/prettier] Replace `getArrayElementSchema·}·from·'../../utils/array` with `shiftArrayErrorsKeys·}·from·'../../utils/validation';⏎import·Widget·from·'../../Widget`

Check warning on line 159 in packages/forms/src/UIForm/fieldsets/Array/Array.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/Array/Array.component.js#L159 

[no-undef] 'process' is not defined.

Check warning on line 3 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js#L3 

[prettier/prettier] Replace `PropTypes·from·'prop-typ` with `classNames·from·'classnam`

Check warning on line 4 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js#L4 

[prettier/prettier] Replace `classNames·from·'classnames';` with `get·from·'lodash/get';⏎import·PropTypes·from·'prop-types';⏎`

Check warning on line 5 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js#L5 

[prettier/prettier] Replace `InlineMessageInformation,·CollapsiblePanel` with `CollapsiblePanel,·InlineMessageInformation`

Check warning on line 7 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js#L6-L7 

[prettier/prettier] Delete `import·get·from·'lodash/get';⏎import·Widget·from·'../../Widget';`

Check warning on line 8 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js#L8 

[prettier/prettier] Insert `';⏎import·Widget·from·'../../Widget`

Check warning on line 149 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.js#L149 

[no-undef] 'process' is not defined.

Check warning on line 3 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js#L1-L3 

[prettier/prettier] Replace `set·from·'lodash/set';⏎import·cloneDeep·from·'lodash/cloneDeep';⏎import·{·screen,·render` with `{·render,·screen`

Check warning on line 5 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js#L5 

[prettier/prettier] Replace `reateCollapsibleFieldset,·{·defaultTitle·}·from·'./CollapsibleFieldset.component';` with `loneDeep·from·'lodash/cloneDeep';⏎import·set·from·'lodash/set';⏎`

Check warning on line 7 in packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/CollapsibleFieldset/CollapsibleFieldset.component.test.js#L7 

[prettier/prettier] Insert `';⏎import·createCollapsibleFieldset,·{·defaultTitle·}·from·'./CollapsibleFieldset.component`

Check warning on line 2 in packages/forms/src/UIForm/fieldsets/Tabs/Tabs.component.js

See this annotation in the file changed.

@github-actions github-actions / ESLint Report Analysis

packages/forms/src/UIForm/fieldsets/Tabs/Tabs.component.js#L2 

[prettier/prettier] Insert `⏎`
View more details on GitHub Actions