Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump react-hook-form to 7.X #4947

Merged
merged 29 commits into from
Nov 6, 2023
Merged

deps: bump react-hook-form to 7.X #4947

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
07be73b
deps: bump react-hook-form to 7.X
romainseb Oct 20, 2023
d18e3ac
add changeset
romainseb Oct 20, 2023
a03bb9a
migrate component :)
romainseb Oct 23, 2023
4d64007
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Oct 23, 2023
71d4be5
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Oct 24, 2023
1174928
Merge 71d4be55bff3902d6a4cc3528cc3692a82ce467c into 59cf99b8f45e996df…
romainseb Oct 24, 2023
9e85cca
chore: yarn-deduplicate
github-actions[bot] Oct 24, 2023
0caddb5
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Oct 24, 2023
b1c52e2
update package.json
romainseb Oct 24, 2023
025fba9
fix rhf provider (for now)
romainseb Oct 25, 2023
e2ad731
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Oct 25, 2023
3aad454
update code
romainseb Oct 25, 2023
936349a
Handle default value
romainseb Oct 25, 2023
7c3dd40
update changeset
romainseb Oct 25, 2023
4772956
Update .changeset/lovely-chefs-remain.md
romainseb Oct 25, 2023
173db74
use RHF7 in design system form
romainseb Oct 25, 2023
3430bed
accessibility is broken :/
romainseb Oct 25, 2023
fe865b1
update
romainseb Oct 31, 2023
4c27c37
chore: update for accessibility
romainseb Oct 31, 2023
e29e1e7
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Oct 31, 2023
3369491
fix conflict issue
romainseb Oct 31, 2023
3e6651e
updatre
romainseb Oct 31, 2023
afa9165
fix e2e tests
romainseb Oct 31, 2023
2cd75a6
paris timezone ...
romainseb Oct 31, 2023
9715383
update typings
romainseb Oct 31, 2023
0119e3a
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Nov 2, 2023
9d80f41
update typings
romainseb Nov 2, 2023
38f8c18
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Nov 3, 2023
9fa7789
Merge branch 'master' into sromain/deps/bump-rhf
romainseb Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/lovely-chefs-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@talend/design-docs': minor
'@talend/react-stepper': minor
'@talend/react-forms': minor
jmfrancois marked this conversation as resolved.
Show resolved Hide resolved
---

deps: bump react-hook-form to 7.X
romainseb marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion packages/design-docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"classnames": "^2.3.1",
"color-contrast-checker": "^2.1.0",
"figma-js": "^1.16.0",
"react-hook-form": "^6.15.8",
"react-hook-form": "^7.47.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"use-overflow": "^1.2.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"react-autowhatever": "10.2.0",
"@talend/react-bootstrap": "^1.35.2",
"react-ace": "10.1.0",
"react-hook-form": "^6.15.8",
"react-hook-form": "^7.47.0",
"react-jsonschema-form": "0.51.0",
"tv4": "^1.3.0"
},
Expand Down
12 changes: 6 additions & 6 deletions packages/stepper/src/stories/Stepper.components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const FormComponentStep1 = () => {
defaultValues: { ...stepsData[0] },
});

const { field, meta } = useController({
const { field, fieldState } = useController({
control: rhf.control,
name: 'randomInput',
rules: {
Expand Down Expand Up @@ -63,7 +63,7 @@ export const FormComponentStep1 = () => {
}}
/>

{meta.invalid && (
{fieldState.invalid && (
<InlineMessageDestructive description={'This field is required'} withBackground />
)}
<Form.Input
Expand Down Expand Up @@ -93,7 +93,7 @@ export const FormComponentStep2 = () => {
defaultValues: { ...stepsData[1] },
});

const { field, meta } = useController({
const { field, fieldState } = useController({
control: rhf.control,
name: 'randomInput',
rules: {
Expand Down Expand Up @@ -124,7 +124,7 @@ export const FormComponentStep2 = () => {
}}
/>

{meta.invalid && (
{fieldState.invalid && (
<InlineMessageDestructive description={'This field is required'} withBackground />
)}
<Form.Input
Expand Down Expand Up @@ -153,7 +153,7 @@ export const FormComponentStep3 = () => {
defaultValues: { ...stepsData[2] },
});

const { field, meta } = useController({
const { field, fieldState } = useController({
control: rhf.control,
name: 'randomInput',
rules: {
Expand All @@ -171,7 +171,7 @@ export const FormComponentStep3 = () => {
<FormProvider {...rhf}>
<Form>
<Form.Fieldset>
{meta.invalid && (
{fieldState.invalid && (
<InlineMessageDestructive description={'This field is required'} withBackground />
)}
<Form.Input
Expand Down
2 changes: 1 addition & 1 deletion packages/storybook-one/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@talend/icons": "^6.60.1",
"@talend/react-components": "^11.0.0",
"@talend/react-dataviz": "^3.0.1",
"react-hook-form": "^6.15.8"
"react-hook-form": "^7.47.0"
},
"devDependencies": {
"@babel/preset-env": "^7.22.9",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15565,10 +15565,10 @@ react-helmet@^6.1.0:
react-fast-compare "^3.1.1"
react-side-effect "^2.1.0"

react-hook-form@^6.15.8:
version "6.15.8"
resolved "https://registry.yarnpkg.com/react-hook-form/-/react-hook-form-6.15.8.tgz#725c139d308c431c4611e4b9d85a49f01cfc0e7a"
integrity sha512-prq82ofMbnRyj5wqDe8hsTRcdR25jQ+B8KtCS7BLCzjFHAwNuCjRwzPuP4eYLsEBjEIeYd6try+pdLdw0kPkpg==
react-hook-form@^7.47.0:
version "7.47.0"
resolved "https://registry.yarnpkg.com/react-hook-form/-/react-hook-form-7.47.0.tgz#a42f07266bd297ddf1f914f08f4b5f9783262f31"
integrity sha512-F/TroLjTICipmHeFlMrLtNLceO2xr1jU3CyiNla5zdwsGUGu2UOxxR4UyJgLlhMwLW/Wzp4cpJ7CPfgJIeKdSg==

react-i18next@^11.18.6:
version "11.18.6"
Expand Down