-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(solid-router): Add a SolidJS driver for TanStack Router #3276
Draft
birkskyum
wants to merge
21
commits into
TanStack:main
Choose a base branch
from
birkskyum:solid-router-remake
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33,278
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkskyum
force-pushed
the
solid-router-remake
branch
from
January 29, 2025 23:47
ea150b8
to
0ff716a
Compare
View your CI Pipeline Execution ↗ for commit b198f85.
☁️ Nx Cloud last updated this comment at |
birkskyum
changed the title
WIP - feat(solid-router): Add a SolidJS driver for TanStack Router
feat(solid-router): Add a SolidJS driver for TanStack Router
Jan 29, 2025
birkskyum
force-pushed
the
solid-router-remake
branch
from
January 29, 2025 23:55
16f810b
to
a7cddce
Compare
birkskyum
force-pushed
the
solid-router-remake
branch
from
January 30, 2025 23:11
d7b94fa
to
0e5cd64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes:
solid-router
androuter-core
#3086Continuation of:
This adds a solid-router package, which is a copied and modified version of the react-router.
The branch isn't complete just yet - the PR is made to increase collaboration.