Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prefix number of ordered list #28

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

vishna
Copy link
Contributor

@vishna vishna commented Aug 1, 2024

closes #27

Description of changes

Added

String _prefixNumber(Node node, int indentLevel)

to delta_to_markdown.dart that figures out (to best of my node traversing abilities) what number and indent each item on the ordered list should have

Added issue_27_test.dart for issue repro

@TarekkMA TarekkMA merged commit 9ffa235 into TarekkMA:master Aug 19, 2024
1 check passed
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (bc19d8e) to head (f6c1d41).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   93.88%   94.24%   +0.36%     
==========================================
  Files           5        5              
  Lines         425      452      +27     
==========================================
+ Hits          399      426      +27     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ordered list incorrect conversion from delta to markdown
2 participants