done #1
Open
done #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,61 +2,91 @@ | |||
| // Write a JavaScript function that takes a customer's name and account balance and returns a string in the format: "CustomerName has a balance of balance KD." | |||
| function formatCustomerBalance(customerName, balance) { | |||
| // Write code here | |||
| return `${customerName} has a balance of ${balance} KD`; | |||
There was a problem hiding this comment.
you forgot to add a dot at the end of the sentence
| //if (books.year > 2010) return title; | ||
| let newArray = []; | ||
|
|
||
| books.filter((book) => { |
There was a problem hiding this comment.
you could have used a forEach instead of filter, because here you are not relaying on the return value of the filter, you are just using to loop over the array
There was a problem hiding this comment.
another way of solving this would be filtering then using map
| // Write code here | ||
| customers.forEach((customer) => { | ||
| sentence.push(`${customer.name} has a balance of ${customer.balance} KD`); |
There was a problem hiding this comment.
you forgot to add a dot at the end of the sentence
There was a problem hiding this comment.
this is working flawlessly, but it would have been better to use map instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.