Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to explicitely set if heap_id_mask or heap_mask should be used. #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

z3ntu
Copy link

@z3ntu z3ntu commented Jul 16, 2016

Apply with MR_QCOM_OVERLAY_HEAP_ID_MASK := 1 or 2 in your BoardConfig.mk. If not set, it will fall back to the old method (>= API 21)

This would fix #101

This is probably the worst C preprocessor cluster, but it seems to work. If you know how it would be better, please tell me :)

Apply with MR_QCOM_OVERLAY_HEAP_ID_MASK := 1 or 2. If not set, it will
fall back to the old method >= API 21
@sndnvaps
Copy link

5270294

this change depend on you kernel

@sndnvaps
Copy link

+    #if (PLATFORM_SDK_VERSION >= 21)
+        ionAllocData.heap_id_mask =
+    #else

this not work for me , so i make my change to fit it ..

@z3ntu
Copy link
Author

z3ntu commented Aug 21, 2016

I meant, that this is a patch that only depends on the setting in the BoardConfig and not a if for every device that uses it (like you did in 5270294)

@sndnvaps
Copy link

it just the patch for my device , but you can modified it to support more devie .

z3ntu added a commit to z3ntu/android_device_qcom_common_cm that referenced this pull request Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

framebuffer_qcom_overlay.h not all API >= 21 kernels have the upper member
2 participants