Show translations in profile languages #2791
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior of the expand/collapse translations button in the new design. Now, unless a particular language is selected in "Show translations in": - if the user has two profile languages or more, then hide non-profile-language translations behind the expand/collapse button. - if the user is logged out or has one profile language or less, then keep the existing behavior of only showing the first five translations. This will hopefully show more relevant results by default.
So that it’s gonna be easier to add custom entries.
This commit changes the behavior of the expand/collapse translations button in the old design. Now, unless a particular language is selected in "Show translations in": - if the user has two profile languages or more, then hide non-profile-language translations behind the expand/collapse button. - if the user is logged out or has one profile language or less, then keep the existing behavior of only showing the first five translations. This will hopefully show more relevant results by default.
This variable counts sentences that are initially hidden, so it should be named "hidden" or "toDisplay" or similar.
Now that this button can hide *all* the translations, it would not make sense to make it say "show n more translations" in that case. Also included the icon inside the translatable string to allow translators to put it at a different place (this should be useful for RTL languages).
Apply the same changes as in 46c8d6b on the new design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the "show n more translations" button works.
Before, it hid all translations that appeared after the 5th one.
With this PR, the behavior is:
Note that there is a performance problem on the new design: when there are lots of translations, it can take more than a second for the all the translations to appear after clicking the expand button. This PR could make this problem even more of a burden.
Note that this PR makes the expand/collapse to always show up on the old design regardless of the user setting.
For these reasons, I left the PR as draft. Feel free to suggest changes or even take over this PR by pushing new commits to the associated branch.