Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve network login webview #38

Merged
merged 48 commits into from
Jul 16, 2024
Merged

improve network login webview #38

merged 48 commits into from
Jul 16, 2024

Conversation

ignyx
Copy link

@ignyx ignyx commented Jul 11, 2024 •
edited
Loading

  • improve webview disposal
  • set user-agent for all networks to Chrome mobile except for Messenger who requires a desktop user-agent in order to display the login form
  • added some javascript to modify page style and auto-decline cookies

@VincePaulin could you please review and improve the style of the messenger page ?

We could also add cookie auto-decline to other networks.

image

VincePaulin and others added 30 commits June 21, 2024 15:31
@VincePaulin
feat: enum check last message funtion
75391c8
@VincePaulin
feat: delete accept all room
ca584ea
@VincePaulin
feat: l10n send error translate
c16c2a8
@VincePaulin
feat: explicit comments
6261e5d
@VincePaulin
feat: matrix sync
6af8707
@VincePaulin
feat: use better boolean logic syntax
bdaf9e9
@VincePaulin
feat: better name function for handleConnection
45605c4
@VincePaulin
feat: ping & createMeta listener
8b8baf4
@VincePaulin
feat: listener whatsapp
2f9fda7
@VincePaulin
feat: listener linkedin
7579b6a
@VincePaulin
feat: better ping stream
8baea5c
@VincePaulin
feat: better stream for meta/linkedin
8dbd3c5
@VincePaulin
feat: better stream whatsapp
370cb46
@VincePaulin
fix: double pop after connect to whatsapp
4fb9c3e
@VincePaulin
feat: rm getWhatsAppNetwork for fromName in model
33b531d
@VincePaulin
feat: comment title section
5607d00
@VincePaulin
feat: utils folder for reduce AddBridge size code
c2c97c7
@VincePaulin
feat: isStillConnected more intuitive
973f61f
@VincePaulin
feat: !isStillConnected instead of isDisconnected
2769d1f
@VincePaulin
feat: RegExpPingPatterns with enum
7964047
@VincePaulin
feat: getLogoutNetworkPatterns with enum
f739ee0
@VincePaulin
feat: matrix syncing background
8c1019a
@VincePaulin
feat: matrix widget reformat
3daee55
@VincePaulin
feat: _getOrCreateDirectChat upgrade
2c305c0
@VincePaulin
feat: MatrixClient rename to MatrixClientWrapper
dfd7f3d
@VincePaulin
feat: rename MatrixClient folder
908e466
@VincePaulin
feat: successSendingPing bool var
3445c74
@VincePaulin
feat: line between debug printing
2937669
@ignyx
fix(auth): specify code auth method with kratos
754d88e
@VincePaulin
feat: delete connectionResult
b816a08
@ignyx ignyx changed the title Fix network login webview improve network login webview Jul 11, 2024
@VincePaulin
Copy link

I've changed the URL to: https://www.messenger.com/login

Screenshot_20240712_170400

@ignyx ignyx marked this pull request as ready for review July 16, 2024 13:28
@ignyx
Copy link
Author

ignyx commented Jul 16, 2024

Brilliant, LGTM

@VincePaulin VincePaulin merged commit 5f8ed61 into dev Jul 16, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignyx @VincePaulin