-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature room bot can be removed after disconnection #4
Feature room bot can be removed after disconnection #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many good things ! Some parts should be broken down into smaller components/functions/variables for better readability. Some errors appear not be handled. Looks great otherwise !
Multiple things arose while initially testing :
Unrecognized error message :
Testing was done on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good ! A few minor details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added the ability to delete a room with a Bot Bridge after trying to disconnect from it.