Feature messenger api #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignyx
requested changes
Oct 14, 2024
lib/pages/add_bridge/add_bridge.dart
Outdated
| } | ||
| } | ||
|
|
||
| void interpretBridgeResponse(http.Response response) { |
There was a problem hiding this comment.
Suggested change
| void interpretBridgeResponse(http.Response response) { | |
| void parseBridgeResponse(http.Response response) { |
| ConnectionStateModel connectionState, | ||
| SocialNetwork network, | ||
| ) async { | ||
| final flowID = network.flowId; |
There was a problem hiding this comment.
the supported flows could be fetched from the API. We should discuss how we choose to do it
VincePaulin
force-pushed
the
feature-messenger-api
branch
from
a56290a to
8edd4b7
Compare
ignyx
requested changes
Oct 15, 2024
lib/pages/add_bridge/add_bridge.dart
Outdated
| final logins = responseJson['logins']; | ||
| if (logins != null && logins.isNotEmpty) { | ||
| final stateEvent = logins[0]['state']?['state_event']; | ||
| return stateEvent == 'CONNECTED' ? ConnectionStatus.connected : ConnectionStatus.notConnected; |
There was a problem hiding this comment.
There can be other states than CONNECTED
ignyx
reviewed
Oct 18, 2024
| case ConnectionStatus.connecting: | ||
| if (kDebugMode) { | ||
| print('Connecting to ${network.name}...'); | ||
| } |
There was a problem hiding this comment.
Should we use this info to display the status to the user ?
| case ConnectionStatus.transientDisconnect: | ||
| if (kDebugMode) { | ||
| print('Transient disconnect detected for ${network.name}.'); | ||
| } |
There was a problem hiding this comment.
Should we use this info to display the status to the user ?
|
Looks good to me ! Just a curiosity about what we should do with some states |
I think about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.