Feature/138 fcm #170
Open
Feature/138 fcm #170
+259
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhello0507
reviewed
Sep 30, 2024
Projects/App/Project.swift
Outdated
| @@ -39,7 +39,9 @@ let project = Project( | |||
| .project(target: "Feature", path: .relativeToRoot("Projects/Feature")), | |||
| .project(target: "Repository", path: .relativeToRoot("Projects/Data")), | |||
| .project(target: "DIContainer", path: .relativeToRoot("Projects/DIContainer")), | |||
| .target(name: "DodamDodamWidget") | |||
| .target(name: "DodamDodamWidget"), | |||
| .external(name: "FirebaseAnalytics"), | |||
Tuist/Package.swift
Outdated
| @@ -30,6 +30,7 @@ let package = Package( | |||
| .package(url: "https://github.com/Mercen-Lee/FlowKit", branch: "main"), | |||
| .package(url: "https://github.com/Mercen-Lee/SignKit", exact: "0.0.2"), | |||
| .package(url: "https://github.com/lorenzofiamingo/swiftui-cached-async-image", exact: "2.1.1"), | |||
| .package(url: "https://github.com/bestswlkh0310/SwiftBok", exact: "1.2.0") | |||
| .package(url: "https://github.com/bestswlkh0310/SwiftBok", exact: "1.2.0"), | |||
There was a problem hiding this comment.
SwiftBok 이제 안 쓰니 삭제 해주세요
삭제하기 전에 브런치 만들어서 아직 남아있나 보네요
leeyoonchae
force-pushed
the
feature/138-fcm
branch
from
94dec33 to
1f2e27c
Compare
Monsteel
reviewed
Feb 13, 2025
Comment on lines
+29
to
+33
| } else { | ||
| let settings: UIUserNotificationSettings = | ||
| UIUserNotificationSettings(types: [.alert, .badge, .sound], categories: nil) | ||
| application.registerUserNotificationSettings(settings) | ||
| } |
There was a problem hiding this comment.
앱의 mininum tarrget이 iOS 15 이상이라, iOS 10.0 기준으로 분기를 태우는건 의미가 없어보입니다.
|
|
||
| // fcm 토큰이 등록 되었을 때 | ||
| func application(_ application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) { | ||
| print("✅ AppDelegate.application.didRegisterForRemoteNotificationsWithDeviceToken - apnsToken \(deviceToken)") |
There was a problem hiding this comment.
곳곳에 디버깅 용도로 찍어놓은 print문이 있는것같은데, 프로덕션에서는 아무 의미가 없기 때문에 제거해주세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.