Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat :: 현재 버스 인원수 표시 #41 #42

Closed
wants to merge 1 commit into from
Closed

feat :: 현재 버스 인원수 표시 #41 #42

wants to merge 1 commit into from

Conversation

wjzlskxk
Copy link
Member

@wjzlskxk wjzlskxk commented Nov 21, 2024 •
edited
Loading

  • 현재 내정보 페이지에서 버스 변경 가능
  • 변경 시 버스의 총인원과 현재 탑승 인원이 표시되지 않아 불편하다는 피드백 수용
  • 기존 버스 변경, 취소 시 캐싱이 되지않던 문제도 함께 해결

before

스크린샷 2024-11-21 오후 2 53 43

after

스크린샷 2024-11-21 오후 2 53 57

s1hyun2
s1hyun2 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@s1hyun2 s1hyun2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다 좋은데 인원수 뜨는거 오른쪽 상단에 뜨게 하면 더 좋을 것 같아요

@ftery0
Copy link
Member

ftery0 commented Nov 21, 2024

인정합니다 인원수가 너무 눈에 보기 어려워요

@ftery0 ftery0 closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1hyun2 s1hyun2 s1hyun2 approved these changes

@ftery0 ftery0 Awaiting requested review from ftery0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wjzlskxk @ftery0 @s1hyun2