Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release(매핑 스타일 리팩토링, DDD스러운 코드): 1.2.3 #285

Merged
merged 41 commits into from
Jan 8, 2023
Merged

release(매핑 스타일 리팩토링, DDD스러운 코드): 1.2.3 #285

merged 41 commits into from
Jan 8, 2023

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Jan 8, 2023 •
edited
Loading

khcho0125 and others added 30 commits January 4, 2023 16:43
@khcho0125
chore: (#278) value 패키지 추가
81d9532
@khcho0125
refactor: (#278) 상수로 명시
13d1bab
@khcho0125
style: (#278) Enum 코드 컨벤션 위반
7b987c1
@khcho0125
feat: (#278) spot name, location & team name unique 컬럼
8721dba
@khcho0125
refactor: (#278) 메서드 참조 지향
35c5fcb
@khcho0125
refactor: (#278) saveAll 반환 값 추가
ace522b
@khcho0125
refactor: (#287) Exception 교체
8f5c8d3
@khcho0125
docs: (#278) 누락된 Javadoc 추가
d0af305
@khcho0125
add: (#278) mapNonNull 확장함수
9a94952
@khcho0125
refactor: (#278) mapNotNull → mapNonNull 변경
4f0a9ff
@khcho0125
chore: (#278) 패키지 이동
25d944c
@khcho0125
revert: (#278) 파트 이름 중복 허용
72f13d2
@khcho0125
chore: (#278) Import 제거...
cb34d18
@khcho0125
revert: (#278) 확장함수 제거
d4dd1a6
@khcho0125
feat: (#278) toDomainNotNull 메서드 추가
03d7354
@khcho0125
refactor: (#278) toDomainNotNull 적용
6e98d14
@khcho0125
revert: (#278) saveAll 반환 값 제거
75c7b74
@khcho0125
merge: (#278) 코드 스타일 리팩토링 (#279)
b0d77af
@khcho0125
chore: (#280) value 패키지 이동
9d947b7
@khcho0125
add: (#280) 요청 값 객체 추가
bb15885
@khcho0125
refactor: (#280) 변경사항 적용
6e6294b
@khcho0125
revert: (#280) 정규표현식 유틸리티 제거
0cabbdd
@khcho0125
refactor: (#280) 누락된 부분 추가
c2d36d5
@khcho0125
refactor: (#280) 정규식 최소, 최대 길이 분리
df3d716
@khcho0125
style: (#280) 상수 명 변경
528793c
@khcho0125
refactor: (#280) value 객체 Length & Range 유효성 검사
90d6f95
@khcho0125
chore: (#280) value 객체 패키지 이동
bcced18
@khcho0125
build: (#280) dev redis properties 환경변수 적용
32da710
@khcho0125
feat: (#280) IllegalArgumentException 예외 메시지 처리
e3ac774
@khcho0125
refactor: (#280) Closeable use 사용 - FileConverter
bde33d8
@softpeanut softpeanut added feat 새로운 기능을 추가 할 경우 refactor 코드 리팩토링 할 경우 labels Jan 8, 2023
@softpeanut softpeanut self-assigned this Jan 8, 2023
@softpeanut softpeanut requested a review from khcho0125 as a code owner January 8, 2023 06:15
@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut softpeanut changed the title release(Request 유효성 검사): 1.2.3 release(매핑 스타일 리팩토링, DDD스러운 코드): 1.2.3 Jan 8, 2023
khcho0125
khcho0125 approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softpeanut softpeanut merged commit cc7031a into main Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khcho0125 khcho0125 khcho0125 approved these changes

Assignees

@softpeanut softpeanut

Labels
feat 새로운 기능을 추가 할 경우 refactor 코드 리팩토링 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

코드 스타일 & 리팩토링
2 participants
@softpeanut @khcho0125