Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#286) AuthCode, AuthCodeLimit 도메인 리팩토링 #292

Merged
merged 8 commits into from
Jan 9, 2023

Conversation

softpeanut
Copy link
Member

작업 내용 설명

  • AuthCode Aggregate 분리
  • AuthCode, AuthCodeLimit Aggregate 중심적으로 변경

주요 변경 사항

  • AuthCodeMapper 직접 구현

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Jan 9, 2023
@softpeanut softpeanut self-assigned this Jan 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@softpeanut
Copy link
Member Author

매퍼 관련된 건 #291 에서 작업하도록 하겠습니다

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #292 (59fcac1) into develop (3db34f2) will decrease coverage by 0.07%.
The diff coverage is 63.79%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #292      +/-   ##
=============================================
- Coverage      41.43%   41.36%   -0.08%     
  Complexity       354      354              
=============================================
  Files            236      236              
  Lines           2558     2587      +29     
  Branches         106      105       -1     
=============================================
+ Hits            1060     1070      +10     
- Misses          1494     1513      +19     
  Partials           4        4              
Impacted Files Coverage Δ
.../simtong/persistence/auth/mapper/AuthCodeMapper.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/domain/auth/model/AuthCode.kt 70.00% <62.50%> (-30.00%) ⬇️
...imtong/domain/auth/usecase/CheckAuthCodeUseCase.kt 100.00% <100.00%> (ø)
...simtong/domain/auth/usecase/ReissueTokenUseCase.kt 100.00% <100.00%> (ø)
...simtong/domain/auth/usecase/SendAuthCodeUseCase.kt 100.00% <100.00%> (ø)
...m/comit/simtong/domain/auth/model/AuthCodeLimit.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db34f2...59fcac1. Read the comment docs.

@softpeanut softpeanut merged commit 3e7aabe into develop Jan 9, 2023
@softpeanut softpeanut deleted the refactor/286-domain-driven-code branch January 9, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants