Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#286) 도메인 용어 적용 #299

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Jan 10, 2023

작업 내용 설명

  • Holiday, Schedule Aggregate의 userId -> employeeId

주요 변경 사항

  • 일부 누락된 애그리거트에 @aggregate 추가
  • Spot, Team Aggregate 줄바꿈 정렬

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Jan 10, 2023
@softpeanut softpeanut self-assigned this Jan 10, 2023
@softpeanut softpeanut changed the base branch from main to develop January 10, 2023 05:22
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #299 (8ed87d1) into develop (ffddcb0) will not change coverage.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #299   +/-   ##
==========================================
  Coverage      38.22%   38.22%           
  Complexity       355      355           
==========================================
  Files            236      236           
  Lines           2880     2880           
  Branches          98       98           
==========================================
  Hits            1101     1101           
  Misses          1775     1775           
  Partials           4        4           
Impacted Files Coverage Δ
...simtong/domain/spot/usecase/ShowSpotListUseCase.kt 100.00% <ø> (ø)
...imtong/persistence/holiday/mapper/HolidayMapper.kt 0.00% <0.00%> (ø)
...tong/persistence/schedule/mapper/ScheduleMapper.kt 0.00% <0.00%> (ø)
...t/simtong/domain/team/usecase/QueryTeamsUseCase.kt 100.00% <100.00%> (ø)
...team/comit/simtong/domain/holiday/model/Holiday.kt 100.00% <100.00%> (ø)
...am/comit/simtong/domain/schedule/model/Schedule.kt 97.67% <100.00%> (ø)
...eam/comit/simtong/domain/user/model/DeviceToken.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffddcb0...8ed87d1. Read the comment docs.

Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@softpeanut softpeanut merged commit 5bcad8a into develop Jan 10, 2023
@softpeanut softpeanut deleted the refactor/286-domain-driven-value branch January 10, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

도메인 중심적인 코드로 리팩토링
2 participants