Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#281) 표현 계층 도메인 의존 #300

Closed
wants to merge 30 commits into from

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Jan 10, 2023

작업 내용 설명

  • presentation → domain 의존
  • 패키지 정리
  • Http Request 요청 핸들링 검토

주요 변경 사항

  • 모든 Response는 Application 계층에서 반환하는 것으로 변경

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added performance 성능을 개선 할 경우 refactor 코드 리팩토링 할 경우 labels Jan 10, 2023
@khcho0125 khcho0125 requested a review from softpeanut as a code owner January 10, 2023 15:50
@khcho0125 khcho0125 self-assigned this Jan 10, 2023
@khcho0125
Copy link
Member Author

파일 양이 좀 많지만 겁먹지 않아도 됩니다...ㅎㅎ
다 패키지 변경 때문임

@khcho0125
Copy link
Member Author

#301 에서 계속 진행하도록 하겠습니다 🚀

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #300 (78f0ddf) into develop (5bcad8a) will increase coverage by 0.69%.
The diff coverage is 45.63%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #300      +/-   ##
=============================================
+ Coverage      38.22%   38.92%   +0.69%     
- Complexity       355      364       +9     
=============================================
  Files            236      234       -2     
  Lines           2880     2880              
  Branches          98       98              
=============================================
+ Hits            1101     1121      +20     
+ Misses          1775     1755      -20     
  Partials           4        4              
Impacted Files Coverage Δ
.../simtong/domain/auth/dto/response/TokenResponse.kt 100.00% <ø> (ø)
...simtong/domain/auth/usecase/ReissueTokenUseCase.kt 100.00% <ø> (ø)
...holiday/dto/request/AppointHolidayPeriodRequest.kt 100.00% <ø> (ø)
...liday/dto/response/QueryEmployeeHolidayResponse.kt 100.00% <ø> (ø)
...ay/dto/response/QueryMonthHolidayPeriodResponse.kt 100.00% <ø> (ø)
...ong/domain/holiday/usecase/AppointAnnualUseCase.kt 100.00% <ø> (ø)
...ain/holiday/usecase/AppointHolidayPeriodUseCase.kt 100.00% <ø> (ø)
...ng/domain/holiday/usecase/AppointHolidayUseCase.kt 100.00% <ø> (ø)
...ong/domain/holiday/usecase/CancelHolidayUseCase.kt 93.33% <ø> (ø)
...in/holiday/usecase/ChangeEmployeeHolidayUseCase.kt 100.00% <ø> (ø)
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcad8a...78f0ddf. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 removed the performance 성능을 개선 할 경우 label Jan 11, 2023
@khcho0125
Copy link
Member Author

파일 변경 개수를 관리하지 못한 관계로... 닫고 다시 만들도록 하겠습니다.

@khcho0125 khcho0125 closed this Jan 12, 2023
@khcho0125 khcho0125 deleted the refactor/281-domain-dependency branch January 23, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants