Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#281) 파일 & 이메일 & 관리자 dto 리팩토링 #308

Merged
merged 9 commits into from
Jan 18, 2023

Conversation

khcho0125
Copy link
Member

작업 내용 설명

  • dto 패키지 이동
  • Data 파일 추가
  • Application Response 적용

주요 변경 사항

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 self-assigned this Jan 14, 2023
@khcho0125 khcho0125 requested a review from softpeanut as a code owner January 14, 2023 14:35
@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Jan 14, 2023
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #308 (aeed9b5) into develop (70288c1) will increase coverage by 0.20%.
The diff coverage is 37.20%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #308      +/-   ##
=============================================
+ Coverage      38.68%   38.88%   +0.20%     
- Complexity       384      393       +9     
=============================================
  Files            239      241       +2     
  Lines           2934     2947      +13     
  Branches          99       99              
=============================================
+ Hits            1135     1146      +11     
- Misses          1793     1795       +2     
  Partials           6        6              
Impacted Files Coverage Δ
...team/comit/simtong/domain/admin/WebAdminAdapter.kt 0.00% <0.00%> (ø)
...mit/simtong/domain/admin/dto/AdminSignInRequest.kt 0.00% <0.00%> (ø)
...team/comit/simtong/domain/email/WebEmailAdapter.kt 0.00% <0.00%> (ø)
...t/simtong/domain/email/dto/CheckAuthCodeRequest.kt 0.00% <0.00%> (ø)
...it/simtong/domain/email/dto/SendAuthCodeRequest.kt 0.00% <0.00%> (ø)
...n/team/comit/simtong/domain/file/WebFileAdapter.kt 0.00% <0.00%> (ø)
...mtong/domain/auth/dto/request/CheckAuthCodeData.kt 100.00% <100.00%> (ø)
...imtong/domain/auth/dto/request/SendAuthCodeData.kt 100.00% <100.00%> (ø)
...imtong/domain/auth/usecase/CheckAuthCodeUseCase.kt 100.00% <100.00%> (ø)
...simtong/domain/auth/usecase/SendAuthCodeUseCase.kt 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70288c1...aeed9b5. Read the comment docs.

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khcho0125 khcho0125 requested a review from softpeanut January 18, 2023 07:29
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit bf6335f into develop Jan 18, 2023
@khcho0125 khcho0125 deleted the refactor/281-file-email-admin-dto-package branch January 18, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants