Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#281) Common dto 패키지 리팩토링 #309

Merged
merged 7 commits into from
Jan 22, 2023

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Jan 18, 2023

작업 내용 설명

  • WebRequest → Request 변경
  • Response 생성 위치 변경

주요 변경 사항

  • 파라미터 요청 값 포장 제거
  • TokenResponse 패키지 위치 변경

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Jan 18, 2023
@khcho0125 khcho0125 self-assigned this Jan 18, 2023
@khcho0125 khcho0125 requested a review from softpeanut as a code owner January 18, 2023 15:59
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #309 (139d98f) into develop (bf6335f) will increase coverage by 0.03%.
The diff coverage is 8.10%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #309      +/-   ##
=============================================
+ Coverage      38.88%   38.92%   +0.03%     
+ Complexity       393      392       -1     
=============================================
  Files            241      240       -1     
  Lines           2947     2944       -3     
  Branches          99       99              
=============================================
  Hits            1146     1146              
+ Misses          1795     1792       -3     
  Partials           6        6              
Impacted Files Coverage Δ
.../simtong/domain/auth/dto/response/TokenResponse.kt 100.00% <ø> (ø)
...simtong/domain/auth/usecase/ReissueTokenUseCase.kt 100.00% <ø> (ø)
.../simtong/domain/user/usecase/AdminSignInUseCase.kt 100.00% <ø> (ø)
...comit/simtong/domain/user/usecase/SignInUseCase.kt 100.00% <ø> (ø)
...comit/simtong/domain/user/usecase/SignUpUseCase.kt 100.00% <ø> (ø)
...imtong/global/security/token/GenerateJwtAdapter.kt 0.00% <ø> (ø)
...team/comit/simtong/domain/admin/WebAdminAdapter.kt 0.00% <ø> (ø)
...am/comit/simtong/domain/common/WebCommonAdapter.kt 0.00% <0.00%> (ø)
...simtong/domain/common/dto/ChangePasswordRequest.kt 0.00% <0.00%> (ø)
...ong/domain/common/dto/FindEmployeeNumberRequest.kt 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6335f...139d98f. Read the comment docs.

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khcho0125 khcho0125 merged commit 0945d06 into develop Jan 22, 2023
@khcho0125 khcho0125 deleted the refactor/281-common-dto-package branch January 22, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants