Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#313) 나머지 영문 명칭 수정 #314

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Feb 11, 2023

작업 내용 설명

  • remain → rest of

주요 변경 사항

No Response

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the docs 문서가 추가되거나 변경되는 경우 label Feb 11, 2023
@khcho0125 khcho0125 self-assigned this Feb 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #314 (be3438d) into develop (580f5b3) will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #314   +/-   ##
==========================================
  Coverage      39.43%   39.43%           
  Complexity       381      381           
==========================================
  Files            234      234           
  Lines           2888     2888           
  Branches         102      102           
==========================================
  Hits            1139     1139           
  Misses          1743     1743           
  Partials           6        6           
Impacted Files Coverage Δ
.../comit/simtong/domain/holiday/WebHolidayAdapter.kt 0.00% <0.00%> (ø)
.../holiday/dto/response/QueryRestOfAnnualResponse.kt 100.00% <100.00%> (ø)
...domain/holiday/usecase/QueryRestOfAnnualUseCase.kt 100.00% <100.00%> (ø)
...team/comit/simtong/domain/holiday/model/Holiday.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580f5b3...be3438d. Read the comment docs.

Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khcho0125 khcho0125 merged commit 55fb4e8 into develop Feb 13, 2023
@khcho0125 khcho0125 deleted the chore/313-word-change branch February 13, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 문서가 추가되거나 변경되는 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants