Skip to content

Commit

Permalink
fix dockerfile build 4
Browse files Browse the repository at this point in the history
  • Loading branch information
shadichy committed Feb 11, 2024
1 parent 74a5b0b commit 39c6045
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dockerimage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ jobs:
run: |
echo "REPO=${GITHUB_REPOSITORY,,}" >>${GITHUB_ENV}
- name: Build the Docker image
run: docker build . --file Dockerfile --tag ${REPO}:master
run: docker build . --file Dockerfile --tag ${REPO}:latest
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
echo -e "a=1" > .rpmpkg/usr/lib/testbin/testbin.conf
chmod +x .rpmpkg/usr/bin/*
docker image ls
docker search tfh-rpm-action
- uses: ./
with:
summary: 'testbin is a test script'
Expand Down Expand Up @@ -56,7 +57,7 @@ jobs:
echo -e "echo hello2" > .rpmpkg/usr/bin/testbin2
echo -e "a=1" > .rpmpkg/usr/lib/testbin/testbin.conf
chmod +x .rpmpkg/usr/bin/*
- uses: team-fuho/tfh-rpm-action@vmaster
- uses: team-fuho/tfh-rpm-action@master
with:
summary: 'testbin is a test script'
package: testbin
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ outputs:
description: 'File name of resulting .rpm debuginfo file.'
runs:
using: 'docker'
image: 'docker://team-fuho/tfh-rpm-action:master'
image: 'docker://team-fuho/tfh-rpm-action:latest'

# Ref: https://haya14busa.github.io/github-action-brandings/
# TODO: update branding if you want.
Expand Down
2 changes: 1 addition & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
set -eu

version=$1

Check warning on line 5 in build.sh

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] build.sh#L5 <ShellCheck.SC2034>

version appears unused. Verify use (or export if used externally).
Raw output
./build.sh:5:1: warning: version appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
tag="jiro4989/build-rpm-action:$version"
tag="team-fuho/build-rpm-action:latest"
docker build --no-cache -t "$tag" .
docker push "$tag"

0 comments on commit 39c6045

Please sign in to comment.