This repository has been archived by the owner on Dec 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add intervals parser #16
Open
hschne
wants to merge
21
commits into
master
Choose a base branch
from
add-intervals-parser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds capabilities for importing opening hours, displaying them in the details view of a location, and filtering locations by them.
Description
In order to import opening hours they have been added to the location csv. The README has been updated with the format used.
interval_parser.py
is responsible for converting the string data there to a database record, anInterval
(couldn't find a better name 🤷♂️). The location model has been updated with a reference to the intervals used, and some migrations were obviously needed for that.To display opening hours to the user
opening_hour_service.py
has been added, which is responsible for returning database records of opening hours to human readable strings. The view renders those in rows, see screenshot.To filter by opening hours picker.js has been used. Not super happy with it, but what can you do. The filtering is then performed in the venue service.
There are also a bunch of smaller changes:
custom.css
for colors, just to try it out. What do you think? :)What to do to try it?
TL;DR