feat: 열람실 이용을 시작할 때 uiState의 오늘 studyCount를 늘리는 로직을 구현 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1msh
approved these changes
Nov 28, 2024
| @@ -107,6 +107,7 @@ fun HomeRoute( | |||
| updateSelectedTime(updatedSelectedTime) | |||
| updateTimePickerVisibility(false) | |||
| updateTimerRunning(true) | |||
| incrementTodayStudyCount() | |||
There was a problem hiding this comment.
increment는 명사라
increase를 메소드 시작 이름으로 추천드립니다.
There was a problem hiding this comment.
저도 이름이 고민이였어서 GPT 검색을 했었는데요 이렇게도 사용 가능하다고 합니다!
Comment on lines
+121
to
+142
| fun incrementTodayStudyCount() { | ||
| _homeUiState.update { currentState -> | ||
| when (currentState) { | ||
| is HomeUiState.Success -> { | ||
| val updatedWeeklyStudyDays: List<WeeklyStudyDay> = | ||
| currentState.weeklyStudyDays.map { studyDay -> | ||
| if (studyDay.date == | ||
| LocalDate.now() | ||
| .format(DateTimeFormatter.ofPattern("M/dd")) | ||
| ) { | ||
| studyDay.copy(studyCount = studyDay.studyCount + 1) | ||
| } else { | ||
| studyDay | ||
| } | ||
| } | ||
| currentState.copy(weeklyStudyDays = updatedWeeklyStudyDays) | ||
| } | ||
|
|
||
| else -> currentState | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
실제 서버엔 적용 안되는 낙관적 UI로 구현하신건가요?
추후 열람실 이용이 종료되면 그제서야 서버에 요청이 들어가는 구조인가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #145
AS-IS
TO-BE
KEY-POINT
SCREENSHOT (Optional)
Screen_recording_20241126_162413.mp4