Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ #66

Merged
merged 7 commits into from
Feb 13, 2025
Merged

_ #66

merged 7 commits into from
Feb 13, 2025

Conversation

xtsea
Copy link
Contributor

@xtsea xtsea commented Feb 13, 2025

Summary by Sourcery

New Features:

  • Introduce a new section in the documentation demonstrating how to achieve super-fast performance using AkenoX-API with FastAPI.

Copy link
Contributor

sourcery-ai bot commented Feb 13, 2025

Reviewer's Guide by Sourcery

This pull request introduces significant documentation enhancements by adding a new 'Super-Fast Perfomance' section to the README, while also modifying the fasthttp method implementation in the akeno module to be synchronous instead of asynchronous.

Sequence diagram for GET /api/cohere endpoint

sequenceDiagram
  actor User
  participant App as FastAPI App
  participant JS as AkenoXToJs

  User->>App: GET /api/cohere?query=value
  App->>JS: Call js.randydev(parameters...)
  JS-->>App: Return response
  App-->>User: JSON response
Loading

Updated class diagram for AkenoX module

classDiagram
  class AkenoXToJs {
    +request_in : aiohttp
    +get_app(docs_url="/docs", redoc_url=None, **args)
    +fasthttp()  // now synchronous
    +randydev(...)
  }

  note for AkenoXToJs "Changed: fasthttp() is now a synchronous method returning the request_in instance"
Loading

File-Level Changes

Change Details Files
Enhanced README.md with a new performance testing section.
  • Removed an extra newline in the dependencies section.
  • Added a detailed 'Super-Fast Perfomance' section explaining the usage of AkenoX-API with FastAPI and rate limiting recommendations.
  • Included example FastAPI endpoints demonstrating API usage and testing approaches.
README.md
Modified the fasthttp method to return the request_in property synchronously.
  • Changed the fasthttp function definition from an asynchronous function to a regular synchronous function.
  • Simplified the method by removing the async/await pattern.
akenoai/akeno.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xtsea - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a disclaimer about the library's stability and support, especially given the warning about potential API blocking.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

README.md Outdated Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@xtsea xtsea merged commit 6d1e61f into test Feb 13, 2025
5 checks passed
xtsea added a commit that referenced this pull request Feb 13, 2025
Merge pull request #66 from TeamKillerX/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant