Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ #8

Merged
merged 11 commits into from
Oct 23, 2024
Merged

_ #8

merged 11 commits into from
Oct 23, 2024

Conversation

xtsea
Copy link
Contributor

@xtsea xtsea commented Oct 23, 2024

Summary by Sourcery

Switch to aiohttp for asynchronous HTTP requests and add performance logging to track execution time. Update the version number to 1.2.4.

Enhancements:

  • Replace httpx with aiohttp for asynchronous HTTP requests to improve performance and compatibility.
  • Add performance logging to measure execution time of asynchronous operations.

Chores:

  • Update version number from 1.2.3 to 1.2.4.

Copy link

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This PR replaces the HTTP client library from httpx to aiohttp, adds performance logging, and bumps the package version. The changes focus on improving the HTTP client implementation and adding timing metrics for API calls.

Sequence diagram for send_log function with aiohttp

sequenceDiagram
    participant Client
    participant aiohttp
    Client->>aiohttp: POST /log
    alt Response status is 200
        aiohttp-->>Client: Return JSON with message
    else Response status is not 200
        aiohttp-->>Client: Return None
    end
Loading

File-Level Changes

Change Details Files
Replace httpx with aiohttp for HTTP client operations
  • Replace httpx.AsyncClient with aiohttp.ClientSession
  • Update response status check from status_code to status
  • Modify response handling to explicitly extract message from JSON response
akenoai/openai.py
Add performance monitoring for API calls
  • Add time tracking using time.perf_counter()
  • Log execution time for API calls in seconds
akenoai/openai.py
Bump package version
  • Update version from 1.2.3 to 1.2.4
akenoai/__version__.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xtsea - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The change from returning the full response.json() to data["message"] could be a breaking change if the API response doesn't always include a "message" key. Consider adding error handling for this case or maintaining the previous behavior.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines 58 to +62
if res is None:
LOGS.warning("Warning: no response API")
LOGS.info(res)
end_time = time.perf_counter()
LOGS.info(f"AIOHTTP: {end_time - start_time:.2f} seconds")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider extracting duplicated performance logging code into a utility function or decorator

This would reduce code duplication between run_image and run methods, making the code more maintainable.

async def log_performance(func):
    async def wrapper(*args, **kwargs):
        start_time = time.perf_counter()
        result = await func(*args, **kwargs)
        end_time = time.perf_counter()
        LOGS.info(f"AIOHTTP: {end_time - start_time:.2f} seconds")
        return result
    return wrapper

@xtsea xtsea merged commit cc40d0a into test Oct 23, 2024
5 checks passed
xtsea added a commit that referenced this pull request Oct 23, 2024
Merge pull request #8 from TeamKillerX/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant