MainActivity: Fix onBackPressed handling for open player #11978
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change b9dd707 accidentally moved the `return` into the `{}`, so the logic would fall through to ``` if (fragmentManager.getBackStackEntryCount() == 1) {` ``` and close the app even though there are still items on the `VideoFragmentDetail` stack. To reproduce: Start video, enqueue another video, then start a third video (which adds one entry to the stack), and press `back` on the expanded video. This should keep the player open and go back to the first 2-video queue, but it actually closes the app before this fix.
AudricV
added
bug
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The change
b9dd707
accidentally moved the
returninto the{}, so the logic would fallthrough to
and close the app even though there are still items on the
VideoFragmentDetailstack.To reproduce:
Start video, enqueue another video, then start a third video (which
adds one entry to the stack), and press
backon the expanded video.This should keep the player open and go back to the first 2-video
queue, but it actually closes the app before this fix.