Implement CronetEngine and HttpEngine support #7

uzu09811 · 2024-11-06T13:46:48Z

This modification is just made to allow people people to override other data sources like Okhttp3, Cronet, HttpEngine.

TobiGr

Thank you for the contribution. Please add more info toyour PR, e.g. why is cronet needed here and why did you choose it over similar dependencies.

TobiGr · 2024-11-09T23:33:18Z

new-player/build.gradle.kts

The detailed info on the libs (group, name, version) are placed in the version catalog

The detailed info on the libs (group, name, version) are placed in the version catalog

now I need to remove them and just keep the important context change as NewPipeTeam will override the get data source obviously.

TobiGr · 2024-11-09T23:33:21Z

new-player/build.gradle.kts

    implementation(libs.coil.compose)
    implementation(libs.reorderable)
    implementation(libs.androidx.media3.session)
    implementation(libs.androidx.media3.exoplayer.dash)
    implementation(libs.androidx.adaptive.android)

+    implementation("org.chromium.net:cronet-embedded:119.6045.31")


why cronet-embedded and not cronet?

Because said by Audric and Stypox but now I need to remove them and just keep the important context change as they will override the get data source obviously

TobiGr · 2024-11-09T23:34:07Z

new-player/src/main/java/net/newpipe/newplayer/repository/MediaRepository.kt

+        } else {
+            if (!CronetProvider.getAllProviders(context).filter { it.isEnabled }.toList().isEmpty()) {
+                val cronetEngine = CronetEngine.Builder(context)
+                    .enableHttpCache(CronetEngine.Builder.HTTP_CACHE_IN_MEMORY, 10 * 1024 * 1024)


Why did you choose exactly this value?

10 x 1024 x 1024 = 10485760 bytes
which means 10MB so highest 10MB wil be cached in memory

@uzu09811 can you please put this value into a named constant so its no MagicNumber.

theScrabi

Ah, after the PR description was added I understood the intention behind the PR.
I like it. @uzu09811 I think you could maybe still add CornetEngine support by creating a meta MediaRepository implementation that only implements getDataSourceFactory(). What do you think?

theScrabi · 2024-11-10T19:37:18Z

new-player/src/main/java/net/newpipe/newplayer/repository/MediaRepository.kt

+        } else {
+            if (!CronetProvider.getAllProviders(context).filter { it.isEnabled }.toList().isEmpty()) {
+                val cronetEngine = CronetEngine.Builder(context)
+                    .enableHttpCache(CronetEngine.Builder.HTTP_CACHE_IN_MEMORY, 10 * 1024 * 1024)


@uzu09811 can you please put this value into a named constant so its no MagicNumber.

Stypox

I am taking care of this PR since @uzu09811 contacted me on Matrix. I would say it's better to let apps choose whether to use cronet or not (because e.g. cronet-embedded adds 9mb). So in the end the PR just modifies the API to allow the usage of cronet in apps. @theScrabi you reviewed an old version of the code for some reason (?).

outdated

new-player/src/main/java/net/newpipe/newplayer/repository/MediaRepository.kt

new-player/src/main/java/net/newpipe/newplayer/logic/MediaSourceBuilder.kt

AudricV · 2024-11-11T15:43:29Z

As a general point of view, except maybe the context change, for a pure HTTP implementation, I don't think changing anything else is needed, as all ExoPlayer data sources for network stacks implement HttpDataSource and not only DataSource.

However, this may allow to use data source with non HTTP origins (like local files), but as I don't really know the NewPlayer structure, I am not certain of this.

theScrabi · 2024-11-11T18:45:23Z

However, this may allow to use data source with non HTTP origins (like local files), but as I don't really know the NewPlayer structure, I am not certain of this.

NewPlayer should support playing local files, so does ExoPlayer. However I don't think HttpDataSource is required for playing local files.

uzu09811 · 2024-11-11T19:29:51Z

DefaultDataSource is needed for local video files because DefaultHttpDataSource will not work for local files

Outdated + I don't have the capacity to review properly the code

theScrabi · 2025-01-03T13:45:34Z

@uzu09811 Sorry for the late reply and for us maintainers cutting and truncating down your Pull request. However, as you see NewPlayer is in an early stage, and with your pull request you triggered some discussions about how we want to solve several problems we may not have thought about before. Especially the interface between two modules is something that needs to be disused and watched closely, as such interfaces must not change or should really change if really required.

We had another discussion about weather a Context should be supplied by the Interface, and we came to the conclusion: No, because the implementation of a MediaRepository will always have access to a Context even if Context is not supplied though a call.

This being said, thank you very much. I have suggested the changes for the Context. If you apply them you are good to go to merge. Now of course I could directly apply the changes, but I think it is cooler for you if you appear in the commit history. :D

theScrabi · 2025-01-03T13:38:52Z

new-player/src/main/java/net/newpipe/newplayer/NewPlayerImpl.kt

@@ -501,7 +501,7 @@ internalPlayStream(mediaSource: MediaSource, playMode: PlayMode) {
        val builder = MediaSourceBuilder(
            repository = repository,
            mutableErrorFlow = mutableErrorFlow,
-            httpDataSourceFactory = repository.getHttpDataSourceFactory(item),
+            dataSourceFactory = repository.getDataSourceFactory(item, app),


Suggested change

dataSourceFactory = repository.getDataSourceFactory(item, app),

dataSourceFactory = repository.getDataSourceFactory(item),

A repository will have the ability to access a Context regardless of weather that Context was supplied from the interface call or not. So this should be removed eventually.

theScrabi · 2025-01-03T13:39:08Z

new-player/src/main/java/net/newpipe/newplayer/repository/MediaRepository.kt

@@ -114,8 +116,9 @@ interface MediaRepository {
    /**
     * Supply a custom [HttpDataSource.Factory]. This is important for Youtube.
     */
-    fun getHttpDataSourceFactory(item: String): HttpDataSource.Factory =
-        DefaultHttpDataSource.Factory()
+    fun getDataSourceFactory(item: String, context: Context): DataSource.Factory {


Suggested change

fun getDataSourceFactory(item: String, context: Context): DataSource.Factory {

fun getDataSourceFactory(item: String): DataSource.Factory {

TobiGr previously requested changes Nov 9, 2024

View reviewed changes

Allow using non-http data sources (e.g. cronet)

197cc9b

Stypox force-pushed the cronet branch from b661c82 to 197cc9b Compare November 10, 2024 19:52

theScrabi requested a review from TobiGr November 10, 2024 19:53

theScrabi approved these changes Nov 10, 2024

View reviewed changes

Stypox approved these changes Nov 11, 2024

View reviewed changes

AudricV previously requested changes Nov 11, 2024

View reviewed changes

uzu09811 added 3 commits November 12, 2024 09:54

Remove unused imports

d2ae01a

Remove unused imports

49c6f46

typo

924d63e

uzu09811 requested a review from AudricV November 29, 2024 09:20

AudricV removed their request for review November 29, 2024 17:51

ShareASmile added dependency Issues and PRs related to dependencies enhancement New feature or request labels Dec 4, 2024

theScrabi removed the request for review from TobiGr January 3, 2025 13:47

theScrabi requested changes Jan 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement CronetEngine and HttpEngine support #7

Implement CronetEngine and HttpEngine support #7

uzu09811 commented Nov 6, 2024 •

edited

Loading

TobiGr left a comment

TobiGr Nov 9, 2024

uzu09811 Nov 10, 2024 •

edited

Loading

TobiGr Nov 9, 2024

uzu09811 Nov 10, 2024 •

edited

Loading

TobiGr Nov 9, 2024

uzu09811 Nov 10, 2024

theScrabi Nov 10, 2024

theScrabi left a comment •

edited

Loading

theScrabi Nov 10, 2024

Stypox left a comment

AudricV commented Nov 11, 2024

theScrabi commented Nov 11, 2024

uzu09811 commented Nov 11, 2024

theScrabi commented Jan 3, 2025 •

edited

Loading

theScrabi Jan 3, 2025

theScrabi Jan 3, 2025

theScrabi Jan 3, 2025

	dataSourceFactory = repository.getDataSourceFactory(item, app),
	dataSourceFactory = repository.getDataSourceFactory(item),

	fun getDataSourceFactory(item: String, context: Context): DataSource.Factory {
	fun getDataSourceFactory(item: String): DataSource.Factory {

Implement CronetEngine and HttpEngine support #7

Are you sure you want to change the base?

Implement CronetEngine and HttpEngine support #7

Conversation

uzu09811 commented Nov 6, 2024 • edited Loading

TobiGr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uzu09811 Nov 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uzu09811 Nov 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theScrabi left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Stypox left a comment

Choose a reason for hiding this comment

AudricV commented Nov 11, 2024

theScrabi commented Nov 11, 2024

uzu09811 commented Nov 11, 2024

theScrabi commented Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uzu09811 commented Nov 6, 2024 •

edited

Loading

uzu09811 Nov 10, 2024 •

edited

Loading

uzu09811 Nov 10, 2024 •

edited

Loading

theScrabi left a comment •

edited

Loading

theScrabi commented Jan 3, 2025 •

edited

Loading