Add link to original message for activated reminders and /listremind #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er for messages like "this"
…r for messages like "this" #2
mctaylors
reviewed
Dec 2, 2023
Octol1ttle
requested changes
Dec 2, 2023
|
TODO: Add link when reminder is off |
Reminder.cs: Message -> MessageId RemindCommandGroup.cs: - check that the message was sent successfully first - removed unnecessary string builder construction - reminder store only original message ID. MemberUpdateService.cs: Link to original message added to the reminder itself as well when it goes off
mctaylors
requested changes
Dec 3, 2023
mctaylors
reviewed
Dec 3, 2023
Octol1ttle
requested changes
Dec 4, 2023
…ginal-message-in-listremind # Conflicts: # src/Commands/RemindCommandGroup.cs
pull-request-size
bot
added
size/XS
pull-request-size
bot
added
size/S
Octol1ttle
requested changes
Dec 5, 2023
Octol1ttle
reviewed
Dec 5, 2023
…ginal-message-in-listremind # Conflicts: # src/Commands/RemindCommandGroup.cs
mctaylors
requested changes
Dec 7, 2023
Octol1ttle
requested changes
Dec 11, 2023
Octol1ttle
requested changes
Dec 11, 2023
Octol1ttle
reviewed
Dec 11, 2023
Octol1ttle
approved these changes
Dec 11, 2023
mctaylors
approved these changes
Dec 11, 2023
mctaylors
changed the title
Apceniy
approved these changes
Dec 11, 2023
Octol1ttle
added
the
type: breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/listremind now has a link to a message with the creation of a reminder for messages like "this"