Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringBuilder & Markdown extensions #206

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Add StringBuilder & Markdown extensions #206

merged 5 commits into from
Dec 4, 2023

Conversation

mctaylors
Copy link
Member

@mctaylors mctaylors commented Dec 4, 2023 •
edited by Octol1ttle
Loading

In this PR, I have added StringBuilder extensions to avoid .Append reuse such as .Append("- ").AppendLine()

Closes #205

@mctaylors mctaylors added the type: change PRs that update current functionality without adding new features or fixing any bugs label Dec 4, 2023
@mctaylors mctaylors requested a review from a team as a code owner December 4, 2023 12:02
@pull-request-size pull-request-size bot added the size/S PRs that change 20-100 lines. label Dec 4, 2023
@Octol1ttle Octol1ttle self-assigned this Dec 4, 2023
Octol1ttle
Octol1ttle reviewed Dec 4, 2023
View reviewed changes
src/Extensions/StringBuilderExtensions.cs Outdated Show resolved Hide resolved
src/Extensions/StringBuilderExtensions.cs Outdated Show resolved Hide resolved
src/Extensions/StringBuilderExtensions.cs Outdated Show resolved Hide resolved
@mctaylors mctaylors requested a review from Octol1ttle December 4, 2023 12:10
Octol1ttle
Octol1ttle requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@Octol1ttle Octol1ttle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still uses of bullet points, but with string interpolation rather than StringBuilder. I think replacing these usages is in the scope of this PR (a static method, similar to Markdown, would probably be better than extensions)

@pull-request-size pull-request-size bot added size/M PRs that change 100-200 lines. and removed size/S PRs that change 20-100 lines. labels Dec 4, 2023
@mctaylors mctaylors requested a review from Octol1ttle December 4, 2023 12:43
@Octol1ttle Octol1ttle added type: refactor/style Changes that improve code quality and styling without affecting functionality and removed type: change PRs that update current functionality without adding new features or fixing any bugs labels Dec 4, 2023
@mctaylors
Mixed changes
c80daa4 
- Add MarkdownExtensions.cs
- Remove AddBulletPoint from StringExtensions.cs
- Add xmldocs to StringBuilderExtensions.cs
@mctaylors
rider if you forget about this one more time i will explode you
26aaecb 
Signed-off-by: mctaylors <[email protected]>
@mctaylors mctaylors changed the title Add StringBuilder extensions Add StringBuilder & Markdown extensions Dec 4, 2023
@mctaylors mctaylors merged commit 18cdc63 into master Dec 4, 2023
@mctaylors mctaylors deleted the appendwithbullet branch December 4, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Octol1ttle Octol1ttle Octol1ttle approved these changes

Assignees

@Octol1ttle Octol1ttle

Labels
size/M PRs that change 100-200 lines. type: refactor/style Changes that improve code quality and styling without affecting functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a new extension method to append bullets
2 participants
@mctaylors @Octol1ttle