-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy 1/26/24 #211
Open
GitLukeW
wants to merge
18
commits into
main
Choose a base branch
from
staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deploy 1/26/24 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deploy 10/02/2023 (#150) * Deploy 09182023 (#143) (#144) * updated cors with staging (#136) (#138) (#139) * Sessionserializer (#141) * updated cors with staging (#136) (#138) * added mentor to session serializer --------- * fix(availability): fix overlapping error (#142) --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> * Forgot password (#148) * Hotfix build celery code * Updated settings file to enable djoser password reset * chore(precommit): setup precommit (#149) * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): update readme * Create SECURITY.md --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> * Deploy 10142023 (#162) * Deploy 09182023 (#143) (#144) * updated cors with staging (#136) (#138) (#139) * Sessionserializer (#141) * updated cors with staging (#136) (#138) * added mentor to session serializer --------- * fix(availability): fix overlapping error (#142) --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> * Forgot password (#148) * Hotfix build celery code * Updated settings file to enable djoser password reset * chore(precommit): setup precommit (#149) * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): update readme * Create SECURITY.md * feat(mentor): add team number to mentor model (#153) * Bump urllib3 from 1.26.16 to 1.26.17 (#151) Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.16...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitLukeW <[email protected]> * Documentation update (#157) * Deploy 10/02/2023 (#150) * Deploy 09182023 (#143) (#144) * updated cors with staging (#136) (#138) (#139) * Sessionserializer (#141) * updated cors with staging (#136) (#138) * added mentor to session serializer --------- * fix(availability): fix overlapping error (#142) --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> * Forgot password (#148) * Hotfix build celery code * Updated settings file to enable djoser password reset * chore(precommit): setup precommit (#149) * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): update readme * Create SECURITY.md --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> * corrected markdown error with Sessions endpoint; added note to Create User endpoint about username being saved as lowercase; formatted JSON code blocks to have proper syntax highlighting * forgot about Logout correction --------- Co-authored-by: GitLukeW <[email protected]> Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> * Dockerizing (#158) * Deploy 10/02/2023 (#150) * Deploy 09182023 (#143) (#144) * updated cors with staging (#136) (#138) (#139) * Sessionserializer (#141) * updated cors with staging (#136) (#138) * added mentor to session serializer --------- * fix(availability): fix overlapping error (#142) --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> * Forgot password (#148) * Hotfix build celery code * Updated settings file to enable djoser password reset * chore(precommit): setup precommit (#149) * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): update readme * Create SECURITY.md --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> * added drf-spectacular to pipfile and generated schema.yml * nitpicking styling * adjusted schema example in models.py * updated SessionSerialiazer example and added AvailabilitySerializer examples * added more serializer examples * updated Pipfile.lock * added requirements.txt from Pipfile * tried dockerizing backend; error while installing cffi * requirements are installed correctly when image is built; build now fails on useradd command * updated pipfile and requirements.txt * changed Dockerfile * added docker-compose file and compose dir to hold Dockerfile and start scripts; build fails during celery worker * docker-compose now builds * removed unecessary script checking that db is set up * django container now runs with docker compose and connects to db container * updated README to match changes made to database connection in settings.py * docker compose yaml now makes api container accessible on 8000 port * celery containers now run properly * added documentation for running project locally with docker containers * added hyperlink to documentation * added more documentation on how to connect to database; updated host port for db container * removed unused package * removed createsuperuser command --------- Co-authored-by: GitLukeW <[email protected]> Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> * Password reset email url (#159) * Hotfix build celery code * Added DOMAIN and SITE_NAME to settings to get correct url for reset password email * Django container creates superuser if none exists and doesn't exit if… (#161) * Django container creates superuser if none exists and doesn't exit if an error is thrown * added documentation note about accessing admin UI --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Andrews <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Andrews <[email protected]>
* fix(deploy): fixing deploy * fix(deploy): fixing deploy
…s in Docker docs (#164) Co-authored-by: GitLukeW <[email protected]>
* docs(linting): adds instructions for flake8 * docs(linting): wrap flake8 in bash
* Deploy 10/02/2023 (#150) * Deploy 09182023 (#143) (#144) * updated cors with staging (#136) (#138) (#139) * Sessionserializer (#141) * updated cors with staging (#136) (#138) * added mentor to session serializer --------- * fix(availability): fix overlapping error (#142) --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> * Forgot password (#148) * Hotfix build celery code * Updated settings file to enable djoser password reset * chore(precommit): setup precommit (#149) * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): setup precommit * chore(precommit): update readme * Create SECURITY.md --------- Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]> * feat(availability): adds status field to model * feat(availability): unique constraint error message clearer * refactor(availability): breaks up 30 mins chunks in serializer * refactor(availability): restores original serializer renames new serializer * refactor(availability): restores original endpoint * chore(urls): updates availability-v2 url for clarity * test(serializer): coverage for availability v2 * test(view): coverage for availability v2 * test(view): coverage for availability delete * chore(linting): clean ups errors * chore(model): availability status updated to confirmed * test(serializer): availability test clean up * chore(urls): clean up spacing * chore(migrations): updating migrations with merge * docs(availability): add new create availability endpoint * docs(availability): updates response to current functionality * docs(user login): update with lowercase username instructions * chore(availability): add note to update to namespace * feat(models): adds modified_at and created_at fields to availability and sessions * chore: add new serializer and view to inits * feat(admin): adds readonly fields of created_at and modified_at * refactor(availability): rework serializer to bulk_create * refactor(availabilities): rework views to create 30 min chunks * chore(linting): cleans up code * chore: remove comment * feat: adds helper functions file * feat: availabilities validating and saving correctly * chore: realign urls * tests: update tests * test(availabilitiy): adds test coverage for serializers. * chore: cleans up linting * refractor(availability): uses header versioning best practices * docs(availability): updates for v2 * chore: cleans up comments * chore: removes v1 versioning comment * test(availability): rework tests to pass * refactor(availabilities): changes from code review * chore: removes parentheses * chore: adds todo * chore(availabilities): remove else statement * feat(availabilities): only returns 30 min chunks in time range * test(helpers): adds coverage to 100% * fix(availability): updates error handling to return consistent error messaging * test(errors): updates tests with new error handling --------- Co-authored-by: GitLukeW <[email protected]> Co-authored-by: Laura Andrews <[email protected]> Co-authored-by: Laura-D-Andrews <[email protected]> Co-authored-by: Nathan Zeager <[email protected]>
Co-authored-by: GitLukeW <[email protected]>
* fix(requirements): cleans up ignored files * docs(requirements): clarifies instructional language
* docs(fix): updated documentation to fix inconsistencies * docs(pr): addressing PR comments --------- Co-authored-by: GitLukeW <[email protected]>
* Change storages config for Django >= 4.2 compatibility This commit updates the storages setting to use the new default backend. It also sets the default public ACL on S3 to true to allow for public access of images. More info about configuring django-storages: https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html#configuration-settings About the STORAGES setting in Django: https://docs.djangoproject.com/en/4.2/ref/settings/#storages * Add UserAdmin class for better user password management in admin The big benefit is that passwords are properly hashed when users are added via the admin. More about customizing the UserAdmin class here: https://docs.djangoproject.com/en/4.2/topics/auth/customizing/#custom-users-and-django-contrib-admin * Use Django's file storage API instead of boto3 so this will work in dev as well * Add tests for user profile photo existence and storage --------- Co-authored-by: GitLukeW <[email protected]>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.0.6...2.0.7) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added several flake8 plugins and black * removed flake8-isort; celery app is instantiated based on new ENVIRONMENT env variable * fixed docs on running celery server locally; added error handling for incorrect ENVIRONMENT value * removed commented out code * fixing linting errors * added flake8-clean-block and fixed errors * added flake8-multiline-containers plugin and fixed errors * fixed multiline container in archive_session_list * fixed indentation * added and configured isort to project; fixed imports on other files * added and configured isort; isort and black configs are now in pyproject.toml; fixed imports; added isort, black, and flake8 to pre-commit * re-added black to pre-commit * corrected Environment Variables section in README; added flake8 plugins as dependencies in pre-commit config * added flake8-quotes plugin; fixed linting errors * fix(precommit): isort, black, flake8, and Branch Name Lint now only run during pre-commit hook * fix(readme): minor formatting JSONs in README * ci(linting): added flake8-isort plugin * docs(hooks): updating the Submitting Code section * docs(linting): added docs on what flake8 errors look like and each plugin's error code prefix * fix: commit-msg-linter no longer requires scope; removed autopep8 * docs: adding $ to shell commands * fix: Branch Name Lint should only run on push * docs: added example to branch name schema * docs: instructions on dealing with pre-commit during rebase * refactor: moved flake8 from packages to dev-packages in Pipfile; locked Pipfile; updated requirements.txt * chore: addressing PR comments * docs: auto-formatted and linted after rebase * chore: reverting sentry-sdk installation * fix: commit script should now handle scope conditionally * fix(commit): testing commit script with scope * docs(commits): added optional scope back to documentation about how we lint the commit message * added several flake8 plugins and black removed flake8-isort; celery app is instantiated based on new ENVIRONMENT env variable fixed docs on running celery server locally; added error handling for incorrect ENVIRONMENT value removed commented out code fixing linting errors added and configured isort; isort and black configs are now in pyproject.toml; fixed imports; added isort, black, and flake8 to pre-commit corrected Environment Variables section in README; added flake8 plugins as dependencies in pre-commit config fix(precommit): isort, black, flake8, and Branch Name Lint now only run during pre-commit hook docs(hooks): updating the Submitting Code section docs(linting): added docs on what flake8 errors look like and each plugin's error code prefix docs: added example to branch name schema chore: addressing PR comments docs: auto-formatted and linted after rebase fix: commit script should now handle scope conditionally docs(commits): added optional scope back to documentation about how we lint the commit message chore(gitignore): removing requirements.txt from cache fix(testing): test set created with set literal instead of set() constructor; added breakpoint to whitelist chore(hooks): switching run tests to pre-push hook chore(docs): updating Submitting Code section in README to include pre-push git hook fix(rebasing): moved branch name linter to pre-push to prevent issues with rebasing * chore: removed 'production' code from celery_settings * fix: deleted Pipfile.lock and reinstalled * fix(docker): added 'localhost' to ALLOWED_HOSTS if DEBUG is true; fixes trying to call on locally-running container API * fix: removed deleted code that made it through merge/rebase * fix: removed $ from shell commands --------- Co-authored-by: Em Sparr <[email protected]>
* chore(linting): cleans up code * chore(devops): pre-commit and coverage added to dev-packages * docs(packages): add instructions on package installation * chore(docs): fixed link
* docs(styling): tries possible option for code output * fix(prepush): reinstalling celery * fix(precommit): adjusting prepush test run * fix(prepush): adds shell for running tests * chore(linting): clean up * chore: remove empty file * docs: updates name of project * docs: remove renaming of app.
* Hotfix build celery code * fix(views-archive-session-list): updated filter to use start_time instead of end_time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
1. Targeted Issue
(The first step to a good solution is knowing the problem. Please link the issue here. Make sure to say 'fixes' before the linked issue)
This PR fixes Issue #...
2. Overview of Solution
(You've put in the hard work, now's your chance to tell us about it. What's your solution in a nutshell?)
3. Tools Used
(Share the tools, libraries, or techniques you've used in your solution.)
4. Testing Strategy
(No code is complete without tests. Outline what you've tested and how.)
5. Future Implications
(Let's anticipate potential effects of your changes. Are there any potential issues down the line?)
6. Screenshots
(A picture is worth a thousand words. Include screenshots of your changes if relevant.)
7. Code Reviewers
(Who else is in the loop? Mention your team or other contributors here.)
Before you go...
Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!