Update support libs tnd mopub to use only necessary dependencies

Change-Id: Ice3d499132adda375a952003bdbb3eda620b9e8b
TeamRainless · Nov 13, 2017 · fdc1b85 · fdc1b85
1 parent 9a579de
commit fdc1b85
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/dependencies.gradle b/dependencies.gradle
@@ -16,7 +16,7 @@ ext {
             androidGradlePlugin        : 'com.android.tools.build:gradle:3.0.0',
 
             // Mopub
-            mopub                      : 'com.mopub:mopub-sdk:4.11.0@aar',
+            mopub                      : 'com.mopub:mopub-sdk-native-static:4.11.0@aar',
 
             // Sample App
             leakCanary                 : 'com.squareup.leakcanary:leakcanary-android:1.5.3',
@@ -35,7 +35,8 @@ ext {
 
             // Other
             picasso                    : 'com.squareup.picasso:picasso:2.5.2',
-            supportV4                  : 'com.android.support:support-v4:26.1.0',
+            supportCompatV4            : 'com.android.support:support-compat:26.1.0',
+            supportCoreV4              : 'com.android.support:support-core-ui:26.1.0',
             retrofit                   : 'com.squareup.retrofit2:retrofit:2.3.0',
             retrofitMock               : 'com.squareup.retrofit2:retrofit-mock:2.3.0',
             retrofitGsonConverter      : 'com.squareup.retrofit2:converter-gson:2.3.0',

diff --git a/tweet-ui/build.gradle b/tweet-ui/build.gradle
@@ -70,7 +70,8 @@ dependencies {
     api project(':twitter-core')
 
     implementation dependency.picasso
-    implementation dependency.supportV4
+    implementation dependency.supportCoreV4
+    implementation dependency.supportCompatV4
     implementation dependency.recyclerview
 
     androidTestCompile dependency.retrofitMock

diff --git a/tweet-ui/internal-build.gradle b/tweet-ui/internal-build.gradle
@@ -93,7 +93,8 @@ dependencies {
     }
 
     implementation dependency.picasso
-    implementation dependency.supportV4
+    implementation dependency.supportCoreV4
+    implementation dependency.supportCompatV4
     implementation dependency.recyclerview
 
     androidTestCompile dependency.retrofitMock

diff --git a/...-mopub/src/test/java/com/twitter/sdk/android/mopub/TwitterStaticNativeAdRendererTest.java b/...-mopub/src/test/java/com/twitter/sdk/android/mopub/TwitterStaticNativeAdRendererTest.java
@@ -25,7 +25,6 @@
 import android.widget.TextView;
 
 import com.mopub.nativeads.BaseNativeAd;
-import com.mopub.nativeads.MoPubCustomEventVideoNative;
 import com.mopub.nativeads.StaticNativeAd;
 import com.mopub.network.MaxWidthImageLoader;
 import com.mopub.network.Networking;
@@ -146,7 +145,5 @@ public void testRenderAdView_shouldReturnPopulatedView() {
     public void testSupports_withCorrectInstanceOfBaseNativeAd_shouldReturnTrue() throws Exception {
         assertTrue(twitterStaticNativeAdRenderer.supports(new StaticNativeAd() {}));
         assertFalse(twitterStaticNativeAdRenderer.supports(mock(BaseNativeAd.class)));
-        assertFalse(twitterStaticNativeAdRenderer
-                .supports(mock(MoPubCustomEventVideoNative.MoPubVideoNativeAd.class)));
     }
 }