-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCL improvements #99
base: master
Are you sure you want to change the base?
UCL improvements #99
Conversation
A couple uses of UniqueID in functions have been kept for backwards compatibility, but honestly I'm not sure if those need to remain either
Won't this break ULX extensions that access ucl.authed? |
That's true, I assumed that there was no need for other addons to access that table directly when I wrote this. Maybe it could just be able to use multiple player identifiers as a key like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, without call PLAYER:UniqueID() somehere in PlayerInitialSpawn before PLAYER.query. Hook call PlayerInitialSpawn sendAutocompletes, gives instant error.
Thought about it for a bit, got an idea for a (sorta) compatibility fix: Using a metatable, we can make __newindex give/set SteamIDs internally even when UniqueIDs are passed. |
Alright, I think I might've finally come up with a potential way to deal with this problem. It's a bit weird, but stick with me here. No matter what ID I tried in testing the length of a SteamID64 (ex. |
NOTE: This change also requires the matching ULX pull request to avoid breakage: TeamUlysses/ulx#226
This PR has two main changes that impact UCL:
ucl.updateClientUCLPlayer( id, data )
anducl.updateClientUCLGroup( name, data )
ucl.authed
now uses SteamID64 internally instead of UniqueIDTested both in a local server and on a public server for a couple weeks now with no regressions found.