Production deployment fix #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketphan02
commented
Apr 23, 2024
Opeyem1a
requested changes
Apr 23, 2024
| @@ -24,9 +24,10 @@ def check_hash(api_token, encrypted_api_token) -> bool: | |||
| """ | |||
| Checks if the API token matches the encrypted API token. | |||
| """ | |||
| print(api_token, encrypted_api_token) | |||
| @@ -29,7 +29,8 @@ | |||
| # SECURITY WARNING: don't run with debug turned on in production! | |||
| DEBUG = False | |||
|
|
|||
| ALLOWED_HOSTS = list(os.environ.get("DJANGO_ALLOWED_HOSTS", "").split(" ")) | |||
There was a problem hiding this comment.
I don't think you should remove ALLOWED_HOSTS!
| @@ -29,7 +29,8 @@ | |||
| # SECURITY WARNING: don't run with debug turned on in production! | |||
| DEBUG = False | |||
|
|
|||
| ALLOWED_HOSTS = list(os.environ.get("DJANGO_ALLOWED_HOSTS", "").split(" ")) | |||
| CORS_ALLOW_HEADERS = "*" | |||
There was a problem hiding this comment.
allow all headers could potentially cause security issues in prod. Please specify exactly the headers you need.
| @@ -4,7 +4,7 @@ | |||
| from pathlib import Path | |||
| import dotenv | |||
|
|
|||
| env_file = next((Path(__file__).parent.parent / "env").glob("*.env")) | |||
| env_file = next((Path(__file__).parent.parent / "env").glob(".env*")) | |||
There was a problem hiding this comment.
doesn't this cause issues if there are multiple env files present in the folder? It seems like it will randomly choose 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.